Repository navigation
Fix minibatch splitting in char-RNN classification tutorial - #3975
ability-spec wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3975
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @ability-spec! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The char-RNN classification tutorial uses floor division to calculate the number of minibatches. With fewer examples than
n_batch_size, training crashes with:ValueError: number sections must be larger than 0.Non-divisible datasets can also produce batches larger than requested.
This change uses ceiling division, preserving balanced batches while supporting small nonempty datasets and respecting the requested batch size.
Validation
git diff --checkpassed.Checklist