Skip to content

tests: replace deepdiff with builtin comparisons - #11044

Merged
radoering merged 1 commit into
python-poetry:mainfrom
radoering:remove-deepdiff
Sep 6, 2026
Merged

tests: replace deepdiff with builtin comparisons#11044
radoering merged 1 commit into
python-poetry:mainfrom
radoering:remove-deepdiff

Conversation

@radoering

Copy link
Copy Markdown
Member

Motivation/Trigger

deepdiff does not allow cachebox 6 (cf qlustered/deepdiff#601) and cachebox 5 does not provide Python 3.15 wheels

Reasoning

We only use a very small portion of deepdiff's features, mostly ignore_order. Apart from that deepdiff may provide slightly better error messages in case of failures but that alone does not seem to be worth an additional (dev) dependency (+ 2 transitive ones).

Regarding ignore_order:

  • We do not need it when comparing dicts.
  • In some cases the order of lists was not fix in the past but is now.
  • The only remaining case where order is not fix, can be handled with sorted().

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@radoering
radoering merged commit 4f85863 into python-poetry:main Sep 6, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant