tests: replace deepdiff with builtin comparisons - #11044
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Trigger
deepdiff does not allow cachebox 6 (cf qlustered/deepdiff#601) and cachebox 5 does not provide Python 3.15 wheels
Reasoning
We only use a very small portion of deepdiff's features, mostly
ignore_order. Apart from that deepdiff may provide slightly better error messages in case of failures but that alone does not seem to be worth an additional (dev) dependency (+ 2 transitive ones).Regarding
ignore_order:sorted().