feat(api): let admins fetch alerts and sequences across organizations#633
Open
MateoLostanlen wants to merge 2 commits into
Open
feat(api): let admins fetch alerts and sequences across organizations#633MateoLostanlen wants to merge 2 commits into
MateoLostanlen wants to merge 2 commits into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| ) | ||
| for url in ("/sequences/unlabeled/latest", "/sequences/unlabeled/latest?risk_score=low"): | ||
| response = await async_client.get(url, headers=auth) | ||
| assert response.status_code == 200, print(response.__dict__) |
| pytest.user_table[0]["id"], pytest.user_table[0]["role"].split(), pytest.user_table[0]["organization_id"] | ||
| ) | ||
| response = await async_client.get("/sequences/unlabeled/latest", headers=admin_auth) | ||
| assert response.status_code == 200, print(response.__dict__) |
| pytest.user_table[1]["id"], pytest.user_table[1]["role"].split(), pytest.user_table[1]["organization_id"] | ||
| ) | ||
| response = await async_client.get("/sequences/unlabeled/latest", headers=agent_auth) | ||
| assert response.status_code == 200, print(response.__dict__) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
- Coverage 93.44% 90.97% -2.48%
==========================================
Files 59 3 -56
Lines 3053 133 -2920
==========================================
- Hits 2853 121 -2732
+ Misses 200 12 -188 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlabeled/latest,all/fromdate,alerts/export) were hard-scoped to the caller's organization; admins now see all organizations, matching the existing behavior of the camera and detection listings.risk_scoreoverride param is ignored for them and documented as such.