Skip to content

Fix/pypy windows extension suffix #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viblo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/pypy windows extension suffix #5368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2855179
Preserve Windows PyPy extension suffix with limited API
Oct 22, 2026
1223d5e
Link Windows PyPy regression changelog to issue 5367
Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/5367.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a regression introduced in v84.2.0 that produced unimportable PyPy extension modules on Windows when ``py_limited_api=True`` by preserving PyPy's ABI-tagged extension suffix.
3 changes: 2 additions & 1 deletion setuptools/command/build_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def get_abi3_suffix():
suffix = get_config_var('EXT_SUFFIX')
if not isinstance(suffix, str) or get_config_var('HAVE_DYNAMIC_LOADING') == 0:
return None
if suffix.endswith('.pyd') and not suffix.startswith('_d'):
# PyPy also uses .pyd on Windows, but does not support CPython's stable ABI.
if suffix == '.pyd' or (suffix.startswith('.cp') and suffix.endswith('.pyd')):
return '.pyd'
if not suffix.startswith('.cpython-'):
return None
Expand Down
24 changes: 23 additions & 1 deletion setuptools/tests/test_build_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
({'EXT_SUFFIX': '_d.cp315-win_amd64.pyd'}, None),
({'EXT_SUFFIX': '_d.pyd'}, None),
({'EXT_SUFFIX': '.pypy310-pp73-x86_64-linux-gnu.so'}, None),
({'EXT_SUFFIX': '.pypy310-pp73-win_amd64.pyd'}, '.pyd'),
({'EXT_SUFFIX': '.pypy310-pp73-win_amd64.pyd'}, None),
({'EXT_SUFFIX': '.pypy311-pp80-win_amd64.pyd'}, None),
({'EXT_SUFFIX': '.dll'}, None),
(
{'EXT_SUFFIX': '.cpython-312-x86_64-cygwin.dll', 'MACHDEP': 'cygwin'},
Expand Down Expand Up @@ -155,6 +156,27 @@ def test_abi3_filename_cross(self, monkeypatch, abi_flags):
'spam', 'normal' + suffix
)

@pytest.mark.parametrize(
'suffix',
[
'.pypy310-pp73-win_amd64.pyd',
'.pypy311-pp80-win_amd64.pyd',
'.pypy310-pp73-x86_64-linux-gnu.so',
'.pypy311-pp80-x86_64-linux-gnu.so',
],
)
@pytest.mark.parametrize('limited_api', [False, True])
def test_pypy_ignores_limited_api(self, monkeypatch, suffix, limited_api):
"""PyPy requires its own suffix even if an extension requests limited API."""
monkeypatch.delenv('SETUPTOOLS_EXT_SUFFIX', raising=False)
monkeypatch.setitem(get_config_vars(), 'EXT_SUFFIX', suffix)
extension = Extension('spam.eggs', ['eggs.c'], py_limited_api=limited_api)
cmd = build_ext(Distribution(dict(ext_modules=[extension])))
cmd.finalize_options()
assert cmd.get_ext_filename('spam.eggs') == os.path.join(
'spam', 'eggs' + suffix
)

def test_ext_suffix_override(self):
"""
SETUPTOOLS_EXT_SUFFIX variable always overrides
Expand Down