Repository navigation
Merge jaraco/skeleton; fix the Ruff 0.17 unused-noqa failure - #5356
Merged
Merged
Conversation
ruff 0.16 flags N999 for projects whose source directory is the distribution name and is redirected to a different import package (e.g. namespace layouts, as used throughout coherent-oss), even though that dotted name is a valid module. Reported upstream as astral-sh/ruff#27801; ignore it here rather than carry a per-file noqa in every such project. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
B006 already catches shared mutable defaults; B008 flags every call regardless of mutability, and escaping it requires enumerating fully-qualified names in each downstream project. Closes jaraco/skeleton#214 Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Ref jaraco/skeleton#210. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…leton#219) Closes jaraco/skeleton#218 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
jaraco
commented
Oct 19, 2026
Ruff 0.17 dropped DTZ011 from its default rule set (it was among the defaults added in 0.16), so RUF100 now flags the noqa directives in setuptools/warnings.py. The trailing comments only justified the suppressions, so drop them along with the directives. Ref jaraco/skeleton#210. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jaraco
force-pushed
the
skeleton-ruff-0.16
branch
from
October 19, 2026 17:27
2d46531 to
6dadc86
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs setuptools with jaraco/skeleton and clears the one lint failure that main currently hits with the latest Ruff.
Skeleton merge
ruff.toml: adds skeleton's upstream ignores for N999, B008 and PLC0414 (Ignore N999 (invalid-module-name) jaraco/skeleton#212, Ignore B008 (function-call-in-default-argument) jaraco/skeleton#215, Ignore PLC0414 (useless-import-alias) jaraco/skeleton#216). Setuptools'# localrules are unchanged..github/workflows/main.yml: addssecrets: inheritto thecollateraljob (Pass secrets through to the reusable test-suite workflow jaraco/skeleton#219). Thetestjob already had it.testjob'swith:block. Setuptools'job,distutilsandfull-testinputs are kept.test-suite.ymlis untouched; skeleton didn't change it. Cygwin, integration, changed-folder checks and the release gating all stay as they were (see Extending the reusable test-suite workflow in heavily-customized downstreams (e.g. setuptools) jaraco/skeleton#211).Ruff
Most of the Ruff 0.16 repair from jaraco/skeleton#210 already landed in d3c5189. Ruff 0.17 then dropped DTZ011 from its default rules, so RUF100 started flagging the two
# noqa: DTZ011directives insetuptools/warnings.py. This removes those directives and keeps the explanatory comments. One comment moves above its line so thatruff formatdoesn't wrap the condition.Nothing under
setuptools/_vendororsetuptools/_distutilschanges.Verification
toxon main with Python 3.14 and Ruff 0.17.1 had one failure,setuptools/warnings.py::ruff(RUF100).toxpasses (1419 passed, mypy clean).Ref jaraco/skeleton#210
🤖 Generated with Claude Code