Promote the Clean Headline Advisory and hub_fetch_run.py Rename to Main by ptr727 · Pull Request #3222 · ptr727/ProjectTemplate

ptr727 · 2026-10-19T08:10:57Z

Print a Clean Verdict's Headline as an Advisory Line in pr_review.py #3221 makes pr_review.py print a clean-verdict Copilot round's headline under CLEAN VERDICT HEADLINE when the round counts no finding, opens no thread, and collapses no block. The line is advisory and changes no exit code. It shares one guard with the flagging reading behind exit 50, through a verdict-set parameter on uncounted_verdict. This implements the maintainer's "print it, do not gate" decision on pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567.
Bump streetsidesoftware/cspell-action from 9.1.0 to 9.2.0 in the actions-deps group across 1 directory #3223, Dependabot's bump of streetsidesoftware/cspell-action from v9.1.0 to v9.2.0, landed on develop after the first go-ahead. It had no Copilot round of its own, and the maintainer accepted its coverage before the merge.
Rename the Carried hub-fetch-run.py Snippet to hub_fetch_run.py #3219 renames the carried hook helper catalog/snippets/hub-fetch-run.py to hub_fetch_run.py. It updates every reference and keeps accepting the former name wherever a carrier that copied it earlier would otherwise misclassify.

#3221 edits pr-review-conduct, so this machine's installed Skills change at release.

Closes #2567
Closes #3143

🤖 Generated with Claude Code

Renames the carried hook helper `catalog/snippets/hub-fetch-run.py` to `hub_fetch_run.py`, applying the snake_case Python file-name standard from #3140. ## Changes - Renames the snippet and updates every reference to it: the Husky.Net and pre-commit hook snippets, both VS Code task snippets, the catalog and snippet READMEs, `GOVERNANCE.md`, `STANDUP.md`, `AUDIT.md`, `scripts/README.md`, `docs/pre-commit-hooks-rollout.md`, `spec/project-types.json`, and the tests. - Keeps accepting the former name in the python-directories action's `CARRIED_HELPERS`, the audit's `CARRIED_PYTHON_HELPERS`, and the `parity.hooks` statements. A repository that copied the helper before this change still holds `hub-fetch-run.py`, and without this the action would warn that its helper is uncovered Python and the audit would classify the repository as Python. A new test asserts the two sets match. - Keeps the provenance label the helper writes, `(hub-fetch-run main)` and `(hub-fetch-run, commit unresolved)`, so carriers using either file name produce the same scope line. ## Does a resync leave both files? Without a new instruction, it would. `spec/files.json` has no entry for the helper, and `STANDUP.md` makes the hook files repository-owned and copied by hand, so no resync step moves or deletes the helper. A carrier that copied the new snippet would end up with both names. `RESYNC.md` step 6 now says to rename the helper in place and update its calls in the same commit. #3141's file-naming check will report any carrier that still holds the hyphenated name, and the exemption sets above cover only Python-type discovery, so they do not hide it from that check. ## Verification - `python3 -m unittest discover -s tests`: 2973 tests OK. `spec/audit.py --selftest` passes, `spec/validate.py` passes, `scripts/build_dist.py --check` reports the generated distributions current, ruff, mypy, markdownlint, and the eol checks are clean. - Mutation checks: removing the former name from the audit set fails the new selftest case, and removing it from the action's set fails both the uncovered test and the parity test. - `local-strict-review` ran three passes. The first two found a stale `parity.hooks` statement, the provenance label, a duplicated set with no test, and two long sentences, all fixed in the later commits. The third pass found nothing. The opt-in `--check sentence-length` still flags 23 long sentences on lines this change touched, but each one only had a path swapped for one of the same word count, so they were already there. Closes on promotion: #3143 🤖 Generated with [Claude Code](https://claude.com/claude-code)  ## Summary by CodeRabbit * **Maintenance** * Standardized the hook helper’s filename to use underscores across setup instructions, editor tasks, and hook configurations. * Updated repository checks to recognize both the current and former filename, preventing either from being reported as an uncovered Python file.  --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

…3221) ## Summary Implements the maintainer's decision on #2567, "print it, do not gate". A clean-verdict Copilot round can state no open finding, open no thread, and collapse no suppressed or previously-missed block while its headline sentence still names a remaining nit. `pr_review.py` read every such round as a clean pass and printed nothing. - `uncounted_verdict` takes the verdict set as a parameter, so the flagging reading behind exit `50` and the new clean reading share one guard. - The digest prints a clean round's headline under `CLEAN VERDICT HEADLINE`. The line is advisory and changes no exit code. It does not try to tell a new nit from one already answered, per the decision. - The usage text, `scripts/README.md`, and `pr-review-conduct` describe the advisory line, with the skill distributions regenerated. ## Tests - A clean verdict whose headline names findings prints the headline, and `status` and `wait` each exit `0`. Each command's output is read on its own. - A clean headline naming an answered thread prints and still exits `0`. - A clean verdict with no headline prose prints no advisory. - A flagging verdict prints no advisory and still exits `50`. Run against the base `pr_review.py`, the two positive tests fail and the two negative tests pass. The full `tests.test_pr_review` suite passes, as do ruff, mypy, prose_lint (including `--check sentence-length`), the eol gate, `spec/validate.py`, `build_dist.py --check`, markdownlint, cspell, and editorconfig-checker. ## Local strict review There were three recorded passes. Round 1 found an overstated exit-code claim on three surfaces, a docstring summary made false by the new parameter, a test docstring with a false causal claim, a merged output buffer, and two long sentences. Round 2 found a pronoun that bound to the wrong noun. Each was fixed. Round 3 found nothing, so no `introduced` finding remains open. Refs #2567 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

coderabbitai · 2026-10-19T08:11:07Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 8845bac6-9c58-4a1a-8ef0-17559404384e

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

🔵 Needs a closer look

The broad cross-cutting changes require final human review.

No open issues 🎉

What changed in this PR

Promotes clean-verdict headline advisories and renames the hook helper to hub_fetch_run.py while preserving legacy compatibility.

Changes:

Adds advisory output without changing exit codes.
Updates helper references, discovery, and audit compatibility.
Refreshes tests, documentation, configurations, and distributed skills.

File	Description
`tests/test_python_directories.py`	Tests helper-name compatibility.
`tests/test_pr_review.py`	Tests advisory behavior.
`tests/test_hub_fetch_run.py`	Updates renamed helper coverage.
`tests/test_cli_usage.py`	Updates discovery tests.
`STANDUP.md`	Updates setup guidance.
`spec/project-types.json`	Updates discovery and hook specifications.
`spec/audit.py`	Supports both helper names.
`scripts/README.md`	Documents the advisory and rename.
`scripts/pr_review.py`	Implements clean headline advisory output.
`RESYNC.md`	Documents helper migration.
`GOVERNANCE.md`	Updates hook guidance.
`docs/pre-commit-hooks-rollout.md`	Updates helper references.
`catalog/snippets/pre-commit/README.md`	Updates pre-commit guidance.
`catalog/snippets/pre-commit/.pre-commit-config.yaml`	Uses the renamed helper.
`catalog/snippets/husky/README.md`	Updates Husky guidance.
`catalog/snippets/husky/pre-commit`	Uses the renamed helper.
`catalog/snippets/hub_fetch_run.py`	Provides the renamed helper.
`catalog/snippets/configs/vscode-tasks.json`	Updates task paths.
`catalog/snippets/configs/vscode-tasks-python.json`	Updates Python task paths.
`catalog/README.md`	Updates catalog references.
`AUDIT.md`	Documents helper-name compatibility.
`.github/skills/pr-review-conduct/SKILL.md`	Updates review guidance.
`.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md`	Updates distributed guidance.
`.claude-plugin/fleet-skills/.source-digests/pr-review-conduct`	Updates the skill digest.
`.agents/skills/pr-review-conduct/SKILL.md`	Updates authored review guidance.
`.github/actions/python-directories/python_directories.py`	Preserves legacy helper discovery exemptions.

_{Review effort: Lite}

ptr727 · 2026-10-19T08:16:30Z

Answering the round's headline, "The broad cross-cutting changes require final human review." This is a caution about the change, not a finding. The round states no open issue and opens no thread, and its file table names all 26 changed files. Each constituent pull request was reviewed on its own head: #3221 at 0cef514b and #3219 at bbd975ca. Each round was "Approval recommended" with 0 threads, and each pull request had a recorded local strict pass attested on it. The final human review it asks for is the maintainer's go-ahead to merge, which this promotion waits on anyway.

codecov · 2026-10-19T08:16:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.52%. Comparing base (d557c3d) to head (83e291c).
⚠️ Report is 401 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   65.52%   65.52%   -0.01%     
==========================================
  Files          17       17              
  Lines        9767     9771       +4     
==========================================
+ Hits         6400     6402       +2     
- Misses       3367     3369       +2

Flag	Coverage Δ
python-3.13	`65.52% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

🔵 Needs a closer look

Broad cross-cutting changes and generated skill updates warrant final human validation.

No open issues 🎉

_{Review effort: Lite}

ptr727 · 2026-10-19T14:09:27Z

Answering the round on 83e291c2 and its headline, "Broad cross-cutting changes and generated skill updates warrant final human validation." This is a caution, not a finding. The round states no open issue and opens no thread. The generated skill updates are build_dist.py output, and CI's --check holds them to their source. The one commit this head adds is #3223, Dependabot's SHA-pin bump of streetsidesoftware/cspell-action from v9.1.0 to v9.2.0 in .github/workflows/validate-task.yml. That pull request had no Copilot round of its own, so the maintainer decides its coverage before this promotion merges.

ptr727 and others added 2 commits October 18, 2026 20:58

Copilot AI lite review requested due to automatic review settings October 19, 2026 08:10

ptr727 changed the title ~~Promote the Clean Verdict Headline Advisory and hub_fetch_run.py Rename to Main~~ Promote the Clean Headline Advisory and hub_fetch_run.py Rename to Main Oct 19, 2026

Copilot started reviewing on behalf of ptr727 October 19, 2026 08:11

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

ptr727 requested a lite review from Copilot October 19, 2026 14:04

Copilot started reviewing on behalf of ptr727 October 19, 2026 14:04

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

ptr727 merged commit 5f278f2 into main Oct 19, 2026
14 checks passed

ptr727 mentioned this pull request Oct 19, 2026

Session Handoff [review-tooling]: Clean Headline Advisory Released as 2.0.1093, #3214 Code-Span Bound Next #3226

Closed

Navigation Menu

Repository navigation

Promote the Clean Headline Advisory and hub_fetch_run.py Rename to Main - #3222

Promote the Clean Headline Advisory and hub_fetch_run.py Rename to Main#3222
ptr727 merged 3 commits into
mainfrom
develop

ptr727 commented Oct 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ptr727 commented Oct 19, 2026

Uh oh!

codecov Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ptr727 commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ptr727 commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

ptr727 commented Oct 19, 2026

Uh oh!

codecov Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

ptr727 commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ptr727 commented Oct 19, 2026 •

edited

Loading

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

codecov Bot commented Oct 19, 2026 •

edited

Loading