Skip to content

Keep a Stopped Group's Issue Out of the backlog-burndown Ranking - #3028

Merged
ptr727 merged 4 commits into
developfrom
feature/3016-burndown-stopped-claim
Oct 14, 2026
Merged

ptr727 merged 4 commits into
developfrom
feature/3016-burndown-stopped-claim

Conversation

@ptr727

@ptr727 ptr727 commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

backlog-burndown's "Grouping and File Claims" sent an abandoned group's issue straight back to the next round's ranking, while "Cleanup Is the Orchestrator's" stops an abandoned group whose branch carries commits develop lacks (or whose tree is dirty) for the maintainer, and a stopped group keeps its branch and its claim. The issue then ended up both ranked and claimed, and later rounds kept deferring it instead of reporting it as stopped.

  • "Grouping and File Claims" routes an abandoned branch through "Cleanup Is the Orchestrator's" rather than returning the issue to the ranking itself. The adjudication sentence is split under the sentence-length cap.
  • "Cleanup Is the Orchestrator's" releases a clean abandon's claim comment and returns its issue to the next round's ranking, and says the group whose check fails is stopped per "Raising a Blocked Question".
  • "Ranking" keeps an issue whose group is stopped out of the ranking, counted, until the maintainer's answer releases that group's claim, and the round's report names it as stopped.
  • "Raising a Blocked Question" records the answer on the issue beside the question, so a later round reads both from durable state.
  • Generated copies under .github/skills/ and .claude-plugin/ regenerated with scripts/build_dist.py.

Closes on promotion: #3016

Local Review

Four recorded local-strict-review passes. Out-of-scope findings filed as #3026 and #3027. The one introduced finding left open after the first push's edit budget (no sentence said the stopped group's claim comment is updated when the answer releases its claim) is fixed in e9c3e61, which also answers the Copilot thread raising it. No introduced finding remains open.

  • introduced, fixed: .agents/skills/backlog-burndown/SKILL.md "Ranking", claim comment not updated on release.

Verification

  • python3 scripts/build_dist.py --check: current.
  • python3 scripts/prose_lint.py --diff origin/develop: clean.
  • python3 scripts/repo_gate.py: all checks ok.
  • python3 spec/validate.py: OK.
  • scripts/docker_lint.py markdownlint, cspell, editorconfig-checker: 0 issues.

🤖 Generated with Claude Code

ptr727 and others added 3 commits October 14, 2026 16:17
An abandoned group whose cleanup fails is stopped and keeps its claim, so
its issue returns to the ranking only once the maintainer's answer releases
the group, rather than being ranked and claimed at once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ranking names a stopped group's issue as unranked until the maintainer's
answer releases the group, so the rule binds where issues are ranked.
A clean abandon releases its claim comment along with returning the issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Ranking exclusion now waits on the answer releasing the stopped group's
claim, and that answer is written on the issue beside the question, so a
later round can read both from durable state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 14, 2026 23:23
@ptr727

ptr727 commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 925e71c4c495c698a62b62917c18a5a93103904d, the content this pull request carries at that commit against develop, and it recorded 2 findings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 115e45df-c218-4fc2-bbe6-0150a637b088
📥 Commits

Reviewing files that changed from the base of the PR and between f9ca2ef and e9c3e61.

⛔ Files ignored due to path filters: 3
  • .claude-plugin/fleet-skills/.source-digests/backlog-burndown is excluded by !.claude-plugin/fleet-skills/**
  • .claude-plugin/fleet-skills/skills/backlog-burndown/SKILL.md is excluded by !.claude-plugin/fleet-skills/**
  • .github/skills/backlog-burndown/SKILL.md is excluded by !.github/skills/**
📒 Files selected for processing: 1
  • .agents/skills/backlog-burndown/SKILL.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Claim comments must be updated or released when a stopped issue resumes ranking.

1 open finding
What changed in this PR

Updates backlog-burndown to keep stopped groups out of ranking until maintainer resolution.

Changes:

  • Clarifies cleanup and stopped-group behavior.
  • Persists blocked-question answers.
  • Regenerates distributed skill copies and source digest.
File Description
.agents/​skills/​backlog-burndown/​SKILL.md Canonical skill updates
.github/​skills/​backlog-burndown/​SKILL.md Generated copy
.claude-plugin/​fleet-skills/​skills/​backlog-burndown/​SKILL.md Generated copy
.claude-plugin/​fleet-skills/​.source-digests/​backlog-burndown Updated source digest

🧠 Review effort: Lite


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .agents/skills/backlog-burndown/SKILL.md
The answer that releases a stopped group's claim is recorded in its claim
comment before the issue is ranked again, so a kept branch's stale comment
cannot collide with the re-formed group.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head e9c3e6143ba80f26df57381b928de6f622e6c84a, the content this pull request carries at that commit against develop, and it recorded 1 finding.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@f9ca2ef). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3028   +/-   ##
==========================================
  Coverage           ?   60.98%           
==========================================
  Files              ?       17           
  Lines              ?     9010           
  Branches           ?        0           
==========================================
  Hits               ?     5495           
  Misses             ?     3515           
  Partials           ?        0           
Flag Coverage Δ
python-3.13 60.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit b13e6b9 into develop Oct 14, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/3016-burndown-stopped-claim branch October 14, 2026 23:38
ptr727 added a commit that referenced this pull request Oct 15, 2026
…ng, and backlog-burndown Re-Dispatch Rules to Main (#3030)

- #2997 adds an updater that keeps the coding-agent tools already
installed on a host current, without installing a tool the maintainer
has not chosen
- #3017 brings the agent-safety READMEs up to the write guard's #3011
readings: `--admin` read inside a quoted `eval` argument, clustered and
cut-short push options, `--branches` as `--all`, `refs/` pattern
destinations, and a double-quoted list expansion as a directory or
commit value failing closed
- #3022 pairs a Copilot overview-table or `Review findings:` entry with
a review thread by the file it names, replacing word overlap, compares
the headline count against everything the round and the pull request
account for, and makes `pr_review.py cleanup` read every page of the
head pull requests, counting only this repository's own
- #3018 has `backlog-burndown` name a new branch when an issue is
dispatched again, name the open pull request a pushed branch still heads
when cleanup reports it, and splits the long cleanup sentence
- #3028 keeps an abandoned group's issue out of the `backlog-burndown`
ranking while that group is stopped for the maintainer, and records the
release on the claim comment
- #3023 makes `gh-write-guard` read a `heads/` push destination as the
branch git completes it to, read `--prune` beside a pattern, `:`,
`--all`, or bare push as a delete of each branch matched, read
`--mirror` as a force and a delete, and read the `@{push}` target
against the configured remote names. A differential against the previous
guard found no deny-to-allow flip
- #3032 subtracts every thread id an open entry links, back-references
included, from the earlier threads `pr_review.py`'s headline shortfall
counts, so a back-referenced thread is no longer counted twice
- #3035 covers the bootstrap upgrade handoff on Linux and Windows, the
root and elevated skips included, and has `bootstrap.ps1` say when the
agent tools report fails
- #3037 makes `gh-write-guard` fail closed when a push target resolves
but the remote names cannot be read

After this merges, the host-safety installer payload changes, so the
maintainer runs the installer after promotion.

Fixes #3009
Fixes #2985
Fixes #3003
Fixes #2993
Fixes #3016
Fixes #3005
Fixes #3007
Fixes #2973

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants