Skip to content

Session Handoff [review-tooling]: Attributed Opener Stripper Released as 2.0.1090, #2567 Design Call Next #3217

Closed

Description

@ptr727

Next steps, in priority order

  1. pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567: a clean-verdict round whose headline names a finding. This waits on the maintainer's design call, which was put to the maintainer at the close of this round. The answer is in this issue's comments, or on pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567 itself. Done looks like the arm pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567 states: closed as not worth a prose reader, or a reader with both tests pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567 names.
  2. End a Code Span at an HTML Block Line in pr_review.py #3214: end a CODE_SPAN at an HTML block line. unwrap now masks through CODE_SPAN, so a stray backtick that pairs across </details>/<details> leaves those wrappers printed raw. Done looks like the constructed case in End a Code Span at an HTML Block Line in pr_review.py #3214 stripped by unwrap, with every other CODE_SPAN reader's tests still green.
  3. Share One Attribute Tail Across the Details and Summary Opener Readers in pr_review.py #3212: one attribute tail for the remaining opener readers. TAGS and HTML_TAG now share ATTRIBUTES. SUMMARY, DETAILS_OPENER, and DETAILS_TAG each still spell their own tail. Done looks like a table test pinning the same opener shapes at every site.
  4. Keep an Emphasis Tag Quoted in Code When reduced Strips Emphasis in pr_review.py #3215: keep an emphasis tag quoted in code when reduced strips emphasis. It is shared by normal, unwrap, and heading_count, so the vetted, printed, and counted text must move together.
  5. Finish the Incidental Count Sweep, Including Counted Section Titles #3169: finish the incidental-count sweep. Carried over, lowest priority.

External blockers

Internal dependencies

State

The parked decision queue

The queue held 0 open issues with the decision label when this was written. #2567 carries no decision label and was put to the maintainer directly at the close of this round, per step 1.

What the last round did

What not to repeat

  • A plain assertion ahead of a subtest loop hides the loop in a revert-proof. On the reverted code, the first plain failure ends the test, so the loop's subtests never run and read as passing. Put plain assertions after the loop, or in a subTest of their own, before trusting which cases fail on the base.
  • A tail of "anything to the next >" reads prose as a tag. [^>]*> ate code-span text, and a letter-led [A-Za-z][^>]* still ate <details element's ... ->. Only a real attribute grammar ended it, and HTML_TAG already held one. Search the file for an existing grammar before writing a tail.
  • unwrap never masked quotations. Any widening of what TAGS matches reaches text a finding quotes, which is what Copilot caught. A stripper needs the same masking its recognizers already use.
  • pr_review.py status exit 50 repeats after the headline is answered. It reads no answer, so that exit on a promotion whose headline caution is answered is not a partial gate.

New learnings

  • None beyond the issues filed and the points above.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 19, 2026
  2. ptr727 commented on Oct 19, 2026

    @ptr727
    OwnerAuthor

    Answer to step 1, given at the close of the round that wrote this link: #2567 is "print it, do not gate". The headline sentence becomes an advisory digest line with exit 0 and no new exit code, recorded on #2567. So step 1 is now ordinary implementation. The decision queue holds 0 issues.

  3. ptr727 commented on Oct 19, 2026

    @ptr727
    OwnerAuthor

    Continued in #3226, round 8 on track review-tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions