Skip to content

Session Handoff [review-tooling]: Tag-Opener Primitive Released as 2.0.1089, TAGS Stripper Next #3211

Closed

Description

@ptr727

Next steps, in priority order

  1. Strip an Attributed Details or Summary Opener Through TAGS in pr_review.py #3208: strip an attributed or self-closed <details> or <summary> opener through TAGS in pr_review.py. TAGS is the one opener reader left off tag_opener, so <details open> and <summary class="x"> print raw from unwrap and stay on an entry_heading read. Done looks like: TAGS ends a tag name where tag_opener does, bounded so an unclosed tag strips nothing past its own line, with a test pinning <details open>, <summary class="x">, and <summary/> as stripped and <summaryx> as kept.
  2. pr_review.py Passes a Clean-Verdict Copilot Round Whose Headline Sentence Names a Finding #2567: a clean-verdict round whose headline names a finding. Needs the maintainer's design call on reading headline prose before any code, so ask before starting it. It carries no decision label, so raise it as a question when it comes up.
  3. Finish the Incidental Count Sweep, Including Counted Section Titles #3169: finish the incidental-count sweep. Carried over, lower priority.

External blockers

Internal dependencies

State

The parked decision queue

The queue held 0 open issues with the decision label when this was written. Nothing is parked.

What the last round did

What not to repeat

  • HTML's tag-name rule is not the one that matters here. The first cut ended a name on a bare /, as the HTML tokenizer does, and an existing test failed: GitHub renders Markdown, and CommonMark hands HTML no tag for <details/x>. The boundary is CommonMark's.
  • A mutation check must revert to the pre-branch code, not to an earlier cut of the branch. One check reverted heading_of's first guard to the branch's own intermediate SUMMARY.match rather than the original startswith, so the test it "proved" passed against the real base. The fourth local pass caught it.
  • A docstring claiming "every reader" draws a finding per exception. Naming TAGS as the exception drew RATE_LIMITED_REPLY next. Scoping the claim by property ("every opener reader that admits an attribute") ended it.
  • The local pass took five rounds on a small diff. Rounds two through four each found defects in the previous round's fix text, the pattern local-strict-review's two-round budget exists for.

New learnings

  • None beyond the issue filed and the points above.

Activity

  1. added
    handoffA link in the session handoff chain, one open issue per track
    on Oct 19, 2026
  2. ptr727 commented on Oct 19, 2026

    @ptr727
    OwnerAuthor

    Continued in #3217, round 7 on track review-tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    handoffA link in the session handoff chain, one open issue per track

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions