Repository navigation
feat: implement banner plugin - #20
Merged
Merged
Conversation
- Add bannerPlugin for rendering banner experiences - Creates fixed position banner at top or bottom - Supports dismissable close button - Auto-shows on experiences:evaluated event - Emits experiences:shown and experiences:dismissed events - Cleans up on sdk:destroy - Comprehensive test coverage (24 tests) - Add jsdom for DOM testing support Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Issue #7: Banner Plugin
Changes
bannerPluginfor rendering banner experiencesexperiences:evaluatedeventexperiences:shownandexperiences:dismissedeventssdk:destroyeventTesting
Configuration
API
banner.show(experience)- Show a bannerbanner.remove()- Remove active bannerbanner.isShowing()- Check if banner is activeCloses #7