fix(mlflow): restore SQL-backed registry support - #1818
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1eae9a76a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Performance BenchmarksCompared
|
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Merge current main into the PR branch while preserving dependency and security updates.
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
mlflow,all-ci, andallextras somlflow-skinnycan access SQLite and other SQL-backed model registries again.sqlparsedependency to 0.6.0, matching fix(deps): bump sqlparse from 0.5.5 to 0.6.0 #1812 and clearing four currently open security advisories.Reproduction
mlflow-skinnyexplicitly excludes SQL storage dependencies. After #1808 removed full MLflow, creating a registered model againstsqlite:///registry.dbfails withModel Registry features are not supported by the store. The same operation succeeds with the restored dependency set, including in an isolated environment containingmlflow-skinnywithout full MLflow.Validation
mlflow-skinnyand no full MLflow installation.uv lock --checkon this macOS host attempts to build an unrelated Linux-only TensorRT placeholder; the exact-head GitHub Linux Lock File Consistency check has already passed.