Replace ANTLR parser with CongoCC - #958
Open
snazy wants to merge 1 commit into
Open
Conversation
Move CEL grammar generation into cel-core using CongoCC and remove the generated-antlr module, shadow jar dependency, and ANTLR runtime wiring. The generated parser now builds internal AST nodes with typed CEL expression conversion hooks, keeping parser construction close to the grammar while preserving the existing parser API and source-location handling. This simplifies dependency management for downstream consumers, removes the relocated ANTLR artifact from the build graph, and makes future grammar changes easier to review in the core module.
XN137
reviewed
Aug 19, 2026
| } else if (ctx instanceof Token) { | ||
| Token token = (Token) ctx; | ||
| location = source.newLocation(token.getLine(), token.getCharPositionInLine()); | ||
| if (ctx instanceof Node) { |
Contributor
There was a problem hiding this comment.
nit: arent we on java 17 now?
| if (e.isEmpty()) { | ||
| assertThat(actualErr).isEmpty(); | ||
| } else { | ||
| assertThat(actualErr).isNotEmpty(); |
Contributor
There was a problem hiding this comment.
isnt this a serious loss of coverage i.e. the expected errors now dont get asserted?
| .isInstanceOf(ScriptCreateException.class) | ||
| .hasMessageStartingWith( | ||
| "parse failed: ERROR: <input>:1:3: Syntax error: mismatched input ',' expecting IDENTIFIER"); | ||
| "parse failed: ERROR: <input>:1:3: Syntax error: Encountered an error"); |
Contributor
There was a problem hiding this comment.
is there no way to keep providing more context to the user?
|
|
||
| parser.addParseListener(parserListener); | ||
|
|
||
| parser.setErrorHandler(new RecoveryLimitErrorStrategy(options.getErrorRecoveryLimit())); |
Contributor
There was a problem hiding this comment.
options.getErrorRecoveryLimit() still exists but is no longer respected ?
are we missing test coverage here ?
| return reportError(node, "invalid literal"); | ||
| } | ||
|
|
||
| private boolean isNegativeNumericLiteral(Node operand) { |
Contributor
There was a problem hiding this comment.
pardon my ignorance, but where is the "negative" property checked in the method body?
| return text; | ||
| } | ||
|
|
||
| private Node firstExpressionChild(List<Node> children, Node ctx) { |
Contributor
There was a problem hiding this comment.
cant many of these helper methods be static?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CEL grammar generation into cel-core using CongoCC and remove the generated-antlr module, shadow jar dependency, and ANTLR runtime wiring.
The generated parser now builds internal AST nodes with typed CEL expression conversion hooks, keeping parser construction close to the grammar while preserving the existing parser API and source-location handling.
This simplifies dependency management for downstream consumers, removes the relocated ANTLR artifact from the build graph, and makes future grammar changes easier to review in the core module.