Repository navigation
fix: resolve spawn EINVAL on Windows for beacon deploy - #78
Merged
Merged
Conversation
On Windows, npm is a .cmd batch file that requires a shell to execute. Without shell:true, child_process.spawn fails with EINVAL. Enable shell mode on Windows only to avoid deprecation warnings on other platforms, and remove the now-unnecessary getNpmCommand helper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn EINVALerror when runningnpm run deploy:beaconon Windowsnpmis a.cmdbatch file —child_process.spawncan't execute it withoutshell: true, causing anEINVALerrorshell: trueonly on Windows (process.platform === 'win32') to avoid Node deprecation warnings on other platformsgetNpmCommand()helper that tried to work around this by usingnpm.cmd(insufficient — the shell is still needed)Test plan
npm run deploy:beacon:dry-runpasses on macOS with no warningsnpm run deploy:beaconworks on Windows🤖 Generated with Claude Code