Repository navigation
perf(html): fill unreserved colspan padding in one step - #635
Merged
Merged
Conversation
#631 skipped the rowspan probe while nothing was reserved, which took the resource-bound test from 11-15 s to under a second under plain Node and let its timeout come down to 5 s. Under coverage instrumentation on a CI runner it still took 6.9 s, because the padding was still spent and pushed one slot at a time, 20 million times, and the coverage job failed. With no reservation the padding is just nulls up to the last column, so it is now spent as one amount and written with Array.prototype.fill. The test takes ~0.1 s with coverage on. The slot-by-slot path stays for rows a rowspan reaches into. Two new tests pin the padding at the column limit and around a reservation; both pass on the old code too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#631 skipped the rowspan probe while nothing was reserved, which took the
resource-bound test from 11-15 s to under a second under plain Node and
let its timeout come down to 5 s. Under coverage instrumentation on a CI
runner it still took 6.9 s, because the padding was still spent and
pushed one slot at a time, 20 million times, and the coverage job failed.
With no reservation the padding is just nulls up to the last column, so
it is now spent as one amount and written with Array.prototype.fill. The
test takes ~0.1 s with coverage on. The slot-by-slot path stays for rows
a rowspan reaches into. Two new tests pin the padding at the column
limit and around a reservation; both pass on the old code too.
bun run testandbun run coverageboth pass locally (10944 tests). This is what has kept thecoverage + sizejob red on #634; the budget itself is fine there.🤖 Generated with Claude Code