Fix(Dashboard): Fix empty card for other plugins#285
Closed
stonebuzz wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Already fixed in development should target support/* and develop branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix !44577
The way the Carbon plugin currently computes reports prevents other plugins from contributing their own report data.
The
$cardsvariable is systematically reset with:$cards = [];However, this variable is actually passed as a parameter and may already contain cards computed by other plugins. Resetting it at this stage discards any previously generated data and prevents proper aggregation of dashboard cards across plugins.
The implementation should preserve the existing contents of
$cardsand append or merge the Dashboard plugin's cards instead of reinitializing the array.