Skip to content

Add origin as query string to requests to plotlyServerURL #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marthacryan wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Add origin as query string to requests to plotlyServerURL #7854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,12 @@ plots.sendDataToCloud = function(gd, serverURL) {

// Open the Cloud login page in a new tab. We keep a reference so we can post
// the chart back to it once Cloud reports that authentication succeeded.
var cloudWindow = window.open(serverURL, '_blank');
// Pass the current page's origin as a query string so Cloud knows where to
// send the CHART_AUTH_SUCCESS message back to.
var uploadUrl = serverURL +
(serverURL.indexOf('?') === -1 ? '?' : '&') +
'origin=' + encodeURIComponent(window.location.origin);
var cloudWindow = window.open(uploadUrl, '_blank');
if(!cloudWindow) {
console.error('Unable to open Plotly Cloud (the popup may have been blocked)');
gd.emit('plotly_exportfail');
Expand Down
Loading