Repository navigation
Fix flaky parallel tests caused by UpgradeCommandTest route cache - #393
Merged
Merged
Conversation
roadmap:upgrade runs route:cache, which cleared and rewrote the shared bootstrap/cache/routes-v7.php. During a parallel run other processes could see the file exist and then fail to require it, and the cache was left behind for later runs and local development. The test now points APP_ROUTES_CACHE at its own temporary file, asserts the routes were cached there, and removes it afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UpgradeCommandTestrunsroadmap:upgrade, which callsroute:cache. That clears and rewrites the sharedbootstrap/cache/routes-v7.php. Two things went wrong:route:cachewould delete it before theyrequired it. Random unrelated tests then failed withrequire(.../bootstrap/cache/routes-v7.php): Failed to open stream.routes-v7.phpin place. The next run became flaky, and local development kept serving cached routes.Fix
The test sets
APP_ROUTES_CACHEto a temporary file of its own (Laravel reads this env value on everygetCachedRoutesPath()call). It asserts the routes were cached there and deletes the file afterwards. Other parallel processes never touch it.view:cacheneeded no change: Laravel'sCompilerEnginealready recompiles when a compiled view disappears mid-request.Testing
main, with a route cache present at the start: 2 of 3 parallel runs failedbootstrap/cachecontains noroutes-v7.php