fix(KAAP-2257): separate public redirect host from internal API host - #77
Closed
mridulgain wants to merge 3 commits into
Closed
fix(KAAP-2257): separate public redirect host from internal API host#77mridulgain wants to merge 3 commits into
mridulgain wants to merge 3 commits into
Conversation
LoginURL() previously reused FederationConfig.Host, the internal Keystone Service URL, to build the browser-facing Shibboleth SSO redirect. On-prem deployments where the internal Service DNS differs from the publicly-resolvable DU FQDN produced broken redirects (KAAP-2257). Add optional PublicHost (publicKeystoneHost), used only in LoginURL() with fallback to Host. All server-to-server Keystone API calls continue to use Host unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Align field naming with the value used in the pf9-openstack-helm dex chart template. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
vaibhavd21
approved these changes
Sep 2, 2026
|
For existing customers ? -
|
Author
Yes, if you o 1, it starts working. That's how I tested locally. However, the config is embedded in a secret which is generated & deployed by helm. So, recommended way is to upgrade the release. |
mridulgain
marked this pull request as draft
September 4, 2026 07:57
Author
|
The internal ep has two issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoginURL()was building the Shibboleth SSO redirect fromFederationConfig.Hostwhich is fine for SAAS. But for onprem/ce the internal Keystone Service URL is used which breaks the SSO redirection on browser (KAAP-2257).ExternalHost(externalKeystoneHost), used only for the redirect, falling back toHostfor backward compatibility. Server-to-server Keystone API calls still useHost.Test plan
go test ./connector/keystone/...Testing: after upgrading the config & dex image
Screen.Recording.2026-09-03.at.12.15.54.PM.mov
But the keystone refuses to honor token request over unsecured http connection