Skip to content

Fix force_refresh_token, the token inspector JWKS link, and dev-key docs - #105

Merged
phoenixy1 merged 1 commit into
mainfrom
adh-dev-keys-jwks-force-refresh
Oct 15, 2026
Merged

phoenixy1 merged 1 commit into
mainfrom
adh-dev-keys-jwks-force-refresh

Conversation

@phoenixy1

Copy link
Copy Markdown
Contributor

Two bugs and some wrong security guidance:

  • force_refresh_token never took effect. oidcClientSchema didn't declare it, so Zod stripped it while parsing client config, and the force-refresh client set was always empty. The schema now accepts it.
  • The token inspector's JWKS link was a 404. It used /.well-known/jwks.json, but oidc-provider serves the key set at /jwks, which the API already uses.
  • The docs said that without JWKS, oidc-provider generates ephemeral keys that rotate on restart. In fact it falls back to a static development key whose private half ships in the npm package (lib/consts/dev_keystore.js), so the real production risk is forged tokens, not token invalidation. The README, CLAUDE.md, env examples, and log messages now say so.

Also:

  • adds COOKIE_SECRET to apps/auth/.env.example
  • fixes the Option B Caddyfile example, which collapsed all three sites onto one bare :8443
  • corrects the security.yml description (it runs a dependency audit and CodeQL, with no container scanning)
  • notes that login is already rate-limited
  • corrects the shared package's dependency list

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@phoenixy1
phoenixy1 marked this pull request as ready for review October 15, 2026 23:55
@phoenixy1
phoenixy1 merged commit 8f973f3 into main Oct 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant