Repository navigation
Fix force_refresh_token, the token inspector JWKS link, and dev-key docs - #105
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
phoenixy1
marked this pull request as ready for review
October 15, 2026 23:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs and some wrong security guidance:
force_refresh_tokennever took effect.oidcClientSchemadidn't declare it, so Zod stripped it while parsing client config, and the force-refresh client set was always empty. The schema now accepts it./.well-known/jwks.json, but oidc-provider serves the key set at/jwks, which the API already uses.JWKS, oidc-provider generates ephemeral keys that rotate on restart. In fact it falls back to a static development key whose private half ships in the npm package (lib/consts/dev_keystore.js), so the real production risk is forged tokens, not token invalidation. The README,CLAUDE.md, env examples, and log messages now say so.Also:
COOKIE_SECRETtoapps/auth/.env.example:8443security.ymldescription (it runs a dependency audit and CodeQL, with no container scanning)🤖 Generated with Claude Code