Repository navigation
Drop the unused .mono selector and a no-op working-directory - #21
Merged
Merged
Conversation
index.html: `.mono, code, pre` becomes `code, pre`. No element in index.html or 404.html carries the mono class. .github/workflows/deploy-worker.yml: "Check the routes" set working-directory: ., which is already where a step runs when the workflow has no defaults block. Comments that described the site as served by Pages or its actions as SHA-pinned now match what is there: - scripts/check-site.sh: the site Worker serves master; Pages is only the rollback target. - worker/wrangler.toml: not_found_handling is what keeps 404.html on a miss, with no reference to Pages serving it today. - .github/dependabot.yml: every action is first-party actions/* on a major tag; the digest pins are the linter images in run: lines, which Dependabot does not read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
index.html:.mono, code, pre { ... }becomescode, pre { ... }. Nothing inindex.htmlor404.htmlhas themonoclass..github/workflows/deploy-worker.yml:working-directory: .removed from "Check the routes". The workflow has nodefaults:block, so the step already runs at the repository root.scripts/check-site.sh: the header said "Legacy Pages serves whatever is on the branch". The site Worker serves master; Pages stays deployed only as the rollback target, asworker/wrangler.tomlsays.worker/wrangler.toml: thenot_found_handlingcomment said the setting keeps "the 404.html that Pages serves today". It now says what it does without the Pages comparison..github/dependabot.yml: the github-actions comment claimed the actions are pinned to commit SHAs. They are first-partyactions/*on major tags; the digest pins are the shellcheck and actionlint images inrun:lines, which Dependabot does not read.Why
A dead selector and a no-op key both read as if something depends on them, and comments that describe Pages serving the site, or actions pinned by SHA, send the next reader to check things that are not there.
Verification
Run locally, each step of
ci.yml:scripts/check-site.sh: site checks passed, 18 ok lines, before and after; also withEXPIRY_WARN_DAYS=90, as the weekly run does.scripts/*.sh: clean.dependabot.ymlload under a duplicate-key-rejecting YAML loader;deploy-worker.ymlhas no top-level or job-leveldefaults.worker/wrangler.tomlparses withtomllib;assetsandroutesunchanged.pkg.hausallowsstyle-src 'unsafe-inline', so editing the inline stylesheet changes no hash.What only CI and the merge can prove
The deploy job (
npx wrangler deployandscripts/check-routes.py) needs the deploy token and runs only on master. The merge deploys the site as every push to master does; the only served change is the one CSS selector.