Repository navigation
Name the style registry the way the other hosts do - #19
Merged
Merged
Conversation
A comment in index.html and the padding check's failure message in check-site.sh referred to the registry by a file name. Both now say "the estate style registry", the wording the other hosts' sources use. Comment and message text only: check-site.sh passes, and a seeded padding change fails with the new message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in
index.htmland the padding check's failure message inscripts/check-site.shreferred to the style registry by a file name. Both now say "the estate style registry", the wording the other hosts' sources use.Verification:
scripts/check-site.shpasses, and a seeded padding change fails with the new message. Pinned shellcheck and actionlint pass. The apex's CSP allows inline styles without a hash, so a comment inside<style>cannot break it.On merge:
deploy-worker.ymlredeploys the apex; the only served change is the comment text.