Repository navigation
Bump wrangler to 4.147.0, which pins undici 7.29.1 - #18
Merged
Merged
Conversation
wrangler 4.141.0's miniflare pins undici 7.29.0 exactly, so npm audit reports ten advisories that no range bump can reach: GHSA-3wwx-pv8p-q78v, GHSA-pmjh-fq2x-6v4x, GHSA-r53p-7pc4-xj5r, GHSA-rfgv-xxqx-mfg5, GHSA-3xpg-4rpp-hhhm, GHSA-2jfj-6hjv-fm6j, GHSA-2gqq-gqf2-x968, GHSA-w293-vg96-wgc3, GHSA-8436-99hf-9mmv and GHSA-rx4f-c7p8-82vq, all fixed in 7.29.1. wrangler 4.144.0 is the first release whose miniflare pins it. Dev-only. wrangler deploy --dry-run builds a byte-identical bundle on both sides (no-op-worker.js, 313 bytes), so the deployed Worker does not change. Under Node 22 / npm 10.9.8, as CI runs it: npm ci clean, scripts/check-site.sh passed, npm audit found 0 vulnerabilities. The lockfile was written with npm 12 so the sharp platform entries keep their libc field, which npm 10 drops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the ten undici rows this repo has in the dependency digest (pkghaus/.github#19):
GHSA-3wwx-pv8p-q78v,GHSA-pmjh-fq2x-6v4x,GHSA-r53p-7pc4-xj5r,GHSA-rfgv-xxqx-mfg5,GHSA-3xpg-4rpp-hhhm,GHSA-2jfj-6hjv-fm6j,GHSA-2gqq-gqf2-x968,GHSA-w293-vg96-wgc3,GHSA-8436-99hf-9mmv,GHSA-rx4f-c7p8-82vq, all fixed in undici 7.29.1.wrangler 4.141.0's miniflare pins undici 7.29.0 exactly, so no range bump reaches it. wrangler 4.144.0 is the first release whose miniflare pins 7.29.1; this takes the current 4.147.0, the same version and resolved tree buildinfos got from Dependabot in pkghaus/buildinfos#21 (the lockfiles match byte for byte apart from the package name).
Merging deploys (
deploy-worker.ymlruns on every push to master). The bundle is unchanged, so the deploy republishes the same Worker with a newer wrangler.Verification
Under Node 22 / npm 10.9.8, as CI runs it:
npm ciclean on the new lockfilescripts/check-site.shpassednpm audit: found 0 vulnerabilities (base: 10 undici advisories)wrangler deploy --dry-runon base and branch:no-op-worker.js(313 bytes) byte-identical, sourcemap identical apart fromsourceRootThe lockfile was written with npm 12 so the
@img/sharp-*entries keep theirlibcfield; npm 10 drops it and would install the musl binaries on glibc as well.