Skip to content

server: minor internal change (release-7.5-20260120-v7.5.6) - #71459

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-7.5-20260120-v7.5.6from
bb7133:backport-69692-release-7.5-20260120-v7.5.6
Sep 22, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:release-7.5-20260120-v7.5.6from
bb7133:backport-69692-release-7.5-20260120-v7.5.6

Conversation

@bb7133

@bb7133 bb7133 commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #69691

Problem Summary: Minor internal improvement.

What changed and how does it work?

Internal change.

Release note

None

Backport to release-7.5-20260120-v7.5.6.

close pingcap#69691

(cherry picked from commit f1be26c)
Signed-off-by: bb7133 <bb7133@gmail.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2026
@bb7133
bb7133 marked this pull request as ready for review September 21, 2026 10:03
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-7.5-20260120-v7.5.6@b12bb34). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.5-20260120-v7.5.6     #71459   +/-   ##
================================================================
  Coverage                               ?   73.0151%           
================================================================
  Files                                  ?       1440           
  Lines                                  ?     420602           
  Branches                               ?          0           
================================================================
  Hits                                   ?     307103           
  Misses                                 ?      94260           
  Partials                               ?      19239           
Flag Coverage Δ
integration 41.1658% <0.0000%> (?)
unit 72.1928% <65.2173%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 49.2658% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Backport the go-farm amd64 assembly compatibility dependency update from upstream pingcap#56652 (8cbd4a0, ref pingcap#56635), keeping go.mod/go.sum/Bazel pins aligned.
Use the cluster-wide etcd client in TestDoRequestRetryLeader so leader discovery examines all members rather than a random single follower. Preserve retry and response assertions.

Signed-off-by: bb7133 <bb7133@gmail.com>
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2026

@wjhuang2016 wjhuang2016 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-22 02:54:13.72610832 +0000 UTC m=+73378.951329427: ☑️ agreed by wjhuang2016.
  • 2026-09-22 06:00:00.811173469 +0000 UTC m=+84526.036394577: ☑️ agreed by YangKeao.

@ti-chi-bot
ti-chi-bot Bot merged commit 96e7bd9 into pingcap:release-7.5-20260120-v7.5.6 Sep 22, 2026
17 of 19 checks passed
@bb7133 bb7133 changed the title server: restore session on change user auth failure (release-7.5-20260120-v7.5.6) server: minor internal change (release-7.5-20260120-v7.5.6) Oct 9, 2026
@pingcap pingcap deleted a comment from coderabbitai Bot Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants