Fix "Ask in ChatGPT" split button border misalignment - #168
Draft
claude[bot] wants to merge 1 commit into
Draft
Conversation
The global 'button { all: unset }' reset in docs/components/styles.css
resets box-sizing to content-box, making the bordered dropdown-chevron
segment of the Ask-in-ChatGPT split button render 34px tall next to the
32px border-box link segment. Restore box-sizing: border-box after the
reset so both segments align.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Nikita Melnikov · Slack thread
Before: on docs pages, the "Ask in ChatGPT" split button's right dropdown-chevron segment renders 2px taller (34px) than the main button segment (32px), so their rounded borders don't line up.
After: both segments are 32px and their borders align, in both light and dark mode (verified with Playwright measurements against
pnpm dev: link and button now bothheight: 32, boxSizing: border-box, identicaltop).How: the global
button { all: unset; }reset indocs/components/styles.css(pulled in via the pricing-page slider component, but bundled globally) resetsbox-sizingtocontent-box, so the chevron<button>'s 1px borders add to its 32px height while the adjacent<a>segment staysborder-box. This PR addsbox-sizing: border-box;right after the reset.Replaces #167, which had misread the request as removing the button.
Generated by Claude Code