Skip to content

Fix sparse set allocation size overflow #23482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crystarm wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix sparse set allocation size overflow #23482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/opcache/jit/ir/ir_private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,9 +495,12 @@ typedef struct _ir_sparse_set {

IR_ALWAYS_INLINE void ir_sparse_set_init(ir_sparse_set *set, uint32_t size)
{
size_t alloc_size = (size_t)size * 2 * sizeof(*set->data);

set->size = size;
set->len = 0;
set->data = (uint32_t*)ir_mem_malloc(sizeof(uint32_t) * 2 * size) + size;
IR_ASSERT(!size || alloc_size / size == 2 * sizeof(*set->data));
set->data = (uint32_t*)ir_mem_malloc(alloc_size) + size;
#ifdef IR_DEBUG
/* initialize sparse part to avoid valgrind warnings */
memset(&IR_SPARSE_SET_SPARSE(set, size - 1), 0, size * sizeof(uint32_t));
Expand Down
Loading