Repository navigation
v0.1 release readiness — license, version surface, doc and workflow fixes - #19
Merged
Merged
Conversation
Final release review found no correctness blockers; this lands the release-prep fixes only: - Add LICENSE (Apache-2.0) — declared by every crate manifest and copied into release tarballs by release.yml, but the file itself was missing. - Report the release version on the daemon /v1/status payload alongside compiler_semantics_version, asserted in the API tests. - Replace hardcoded developer paths in the VHS demo tapes with a generic PATH plus an install note. - Correct stale "cached is classification-only" claims (roadmap status table) and mark convergence-review.md as a point-in-time record — cache reuse has been executable since PR #18. - Add docs/v0.1-release-notes.md and docs/v0.1-final-review.md.
The phase implementation notes are presented as current audited status, so three claims that predated PR #17/#18 needed correcting: - Phase 3 still called cached classification-only; it is executable verified adoption (live output-identity check, build fallback on stale evidence), covered by engine tests and the Nessie e2e. - Phase 5 claimed promotion records were artifact-only; they persist to the state store's promotions table since PR #17. - Phase 8 claimed the API had no plan endpoint; /v1/plan exists.
- release.yml: the x86_64 leg pinned macos-13, a runner image GitHub retired in December 2025 — a v* tag would fail to schedule. Moved to macos-15-intel, the only remaining x86_64 macOS runner. - README: the status section called Phase 1 "done" while the audited roadmap table records "partial" (no partition-level scheduler tests); aligned to the audit verdict. - v0.1-final-review.md: corrected the fixture count (39, not 36) and recorded the runner and README fixes.
Point-in-time audit and validation records (convergence review, dbt migration audit, fresh-container validation, readiness report, final release review) are working documents, not project documentation — removed from docs/ and every reference scrubbed (README index, roadmap table, blog sources). The release notes stay: they are the user-facing record of what ships.
…ball copy Review on #19: - LICENSE was a corrupted Apache-2.0 — Section 8 spliced warranty text where the limitation-of-liability terms belong. Replaced verbatim with the official ASF LICENSE-2.0.txt. - Restored docs/v0.1-final-review.md as the release report the handoff required, folding in the load-bearing evidence from the removed intermediate reports: the live 100/1k/5k benchmark table, the regression-locked correctness findings, the dbt migration audit results, and the fresh-container validation record. - release.yml: dropped `2>/dev/null || true` from the README/LICENSE copy — a release now fails loudly rather than shipping unlicensed tarballs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final release-gate pass over the post-PR #18 baseline. The tree is releasable as v0.1.0; this branch lands only the genuine release-prep fixes — no feature work.
release.yml, but the file itself was missing — tarballs would have shipped without it.release.yml's x86_64 leg pinnedmacos-13, retired by GitHub in December 2025 — av*tag would have failed to schedule. Moved tomacos-15-intel./v1/statusreportsversionalongsidecompiler_semantics_version, asserted in the API tests.cacheddescribed as classification-only (executable verified adoption since PR feat: executable cache reuse — verified cross-environment adoption #18), promotion records described as artifact-only (persisted topromotionssince PR feat: portable audit evidence — store-first promotion records, environment binding lifecycle, source qualification #17), "no plan endpoint" (/v1/planexists), and the README's Phase-1 verdict aligned to the audited "partial".docs/; every reference scrubbed.docs/is now strictly user-facing;docs/v0.1-release-notes.mddrafted for the release.Test plan
cargo fmt --all -- --check— cleancargo clippy --workspace --all-targets -- -D warnings— cleancargo test --workspace— 582 passed, 0 failed, 10 ignoredscripts/dogfood.shDuckDB leg — 16/16cargo install --path crates/phlo-transform-cli --lockedto a clean root — installed binary passes--version,init,check,run --adapter duckdbon a fresh directorycargo package -p phlo-transform-sql— packages and verify-builds; dependent crates fail only on unpublished internal deps, as expected pre-publish