Skip to content

ENH : Add Angrist-Krueger QOB (1980 Census) dataset#2

Open
Dijo-404 wants to merge 3 commits into
pgmpy:mainfrom
Dijo-404:feat/iv-1980-census-extract
Open

ENH : Add Angrist-Krueger QOB (1980 Census) dataset#2
Dijo-404 wants to merge 3 commits into
pgmpy:mainfrom
Dijo-404:feat/iv-1980-census-extract

Conversation

@Dijo-404

Copy link
Copy Markdown
  • This PR adds the Angrist-Krueger QOB (1980 Census) dataset to the example_datasets repository.
  • Requested by @DARHWOLF in main pgmpy PR to allow for verification of the dataset and its associated tags.

Related PR: pgmpy/pgmpy#2737

@DARHWOLF DARHWOLF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, may I request the following changes:-

@DARHWOLF DARHWOLF mentioned this pull request Mar 4, 2026
1 task
@Dijo-404

Dijo-404 commented Mar 4, 2026

Copy link
Copy Markdown
Author

Thanks, may I request the following changes:-

* please move this outside the `real` directory. This dataset will have its own directory.

* please include the License file from https://github.com/pgmpy/example_datasets/blob/main/real/LICENSE

* please add a readme for this dataset's directory.

* please add this dataset to the repository's main readme.

Sure working on it.

Copilot AI review requested due to automatic review settings March 4, 2026 12:13
@Dijo-404 Dijo-404 force-pushed the feat/iv-1980-census-extract branch from c3d088b to eb77a20 Compare March 4, 2026 12:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Angrist–Krueger Quarter-of-Birth (1980 Census) dataset to this example_datasets repository so it can be referenced/validated by pgmpy (per pgmpy#2737).

Changes:

  • Introduces a new angrist-krueger-qob/ dataset folder with dataset documentation and CC0 license text.
  • Adds the dataset listing entry to the repository root README.md.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
angrist-krueger-qob/README.md Adds dataset description, citation, and file listing.
angrist-krueger-qob/LICENSE Adds CC0 1.0 Universal license text for the dataset folder.
README.md Adds a new entry pointing to the Angrist–Krueger QOB dataset folder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread angrist-krueger-qob/README.md
@Dijo-404 Dijo-404 closed this Mar 4, 2026
@Dijo-404 Dijo-404 force-pushed the feat/iv-1980-census-extract branch from eb77a20 to 098b54e Compare March 4, 2026 16:22
@Dijo-404

Dijo-404 commented Mar 4, 2026

Copy link
Copy Markdown
Author

Accidentally closed it, having some merge conflicts, working on it

@Dijo-404

Dijo-404 commented Mar 4, 2026

Copy link
Copy Markdown
Author

Fixed the issues and added the requested changes. Let me know if everything looks good now

@Dijo-404 Dijo-404 reopened this Mar 4, 2026
@Dijo-404 Dijo-404 closed this Mar 6, 2026
@Dijo-404 Dijo-404 force-pushed the feat/iv-1980-census-extract branch from 333f67f to 977aa9c Compare March 6, 2026 06:28
@Dijo-404 Dijo-404 reopened this Mar 6, 2026

@Dijo-404 Dijo-404 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the requested changes

@DARHWOLF DARHWOLF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when AA approves

Comment thread angrist-krueger-qob/README.md
@DARHWOLF

DARHWOLF commented Mar 6, 2026

Copy link
Copy Markdown
Member

I'm not sure why there is a need to force-push?

@Dijo-404

Dijo-404 commented Mar 6, 2026

Copy link
Copy Markdown
Author

I'm not sure why there is a need to force-push?

Every time I sync my fork and pull the latest updates to the branch, I get a merge conflict. That's why I had to rebase and force-push

@Dijo-404 Dijo-404 force-pushed the feat/iv-1980-census-extract branch from c8f157b to f78b09c Compare March 6, 2026 09:55
@Dijo-404 Dijo-404 closed this Mar 23, 2026
@Dijo-404 Dijo-404 force-pushed the feat/iv-1980-census-extract branch from f78b09c to 8b6b15a Compare March 23, 2026 16:33
@Dijo-404 Dijo-404 reopened this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants