Skip to content

Add backendRefs group and kind to httproute.yaml - #10222

Open
flipper wants to merge 1 commit into
pgadmin-org:masterfrom
flipper:flipper-patch-1
Open

Add backendRefs group and kind to httproute.yaml#10222
flipper wants to merge 1 commit into
pgadmin-org:masterfrom
flipper:flipper-patch-1

Conversation

@flipper

@flipper flipper commented Aug 2, 2026

Copy link
Copy Markdown

When an HTTPRoute is created with an unset group, kind and weight, the fields are defaulted.

This causes tools like ArgoCD to detect a diff.

This PR sets the fields explicitly.

Summary by CodeRabbit

  • Bug Fixes
    • Updated default HTTP route backend references to include the required Gateway API details, improving routing compatibility while preserving the configured service and port.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d5c78670-fc18-4dc6-9848-2d2e4e4689ad

📥 Commits

Reviewing files that changed from the base of the PR and between 067f7af and 2f1b04c.

📒 Files selected for processing (1)
  • pkg/helm/templates/httproute.yaml

Walkthrough

The Helm HTTPRoute template now includes explicit Gateway API group, kind, and weight fields in the default backend reference. The configured service name and port remain unchanged.

Changes

HTTPRoute backend configuration

Layer / File(s) Summary
Define the backend reference
pkg/helm/templates/httproute.yaml
The default backend reference sets an empty API group, Service kind, and weight 1. It retains the configured service name and port.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change to add Gateway API group and kind fields to HTTPRoute backend references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant