fix(ppstack): restore model-diverse review roles - #63
Open
peterpme wants to merge 1 commit into
Open
Conversation
Route Reflect, How critique, Interrogate, Peer Review, and Arena through pinned family roles. Validate the role matrix before the skill installer changes live links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #58 replaced task-specific model routing with repeated calls to one generic role. Reflect still named three different review lenses, but all three ran on the same Grok reviewer. How critique, Interrogate, and Arena retained language about model diversity while their workflows also repeated one role.
The role name must select the model. A failed lane must remain unavailable instead of silently changing its model or purpose.
Scope
reviewer-sol,reviewer-grok,reviewer-fable, andreviewer-terraagents.candidate-*writers for Arena worktrees.pi/settings.json.check-model-diversity.mjsto reject missing roles, duplicate reviewer selectors, mutation tools on reviewers, disabled selectors, and skill routing drift before installation.The audit covered PRs #58, #60, #61, and #62. PR #58 introduced the collapsed lanes. PRs #60 and #61 retained explicit Fable and peer-review routing. PR #62 changes implementation roles but does not introduce another model-diversity loss.
Tradeoffs
The dedicated roles add eight small agent profiles. This keeps model selection out of workflow calls and gives status output a stable role name.
The direct xAI Grok selector currently returns a credit error. The Grok roles use the verified
opencode/grok-4.6selector instead.Blast Radius
The change affects global Pi agent and settings links after
install.sh skillsruns and Pi restarts. The current live Pi process remains unchanged. PR #62 touches some of the same ppstack files and may need a rebase after one PR merges.Verification
node skills/scripts/check-model-diversity.mjspassed.bash -n install.sh skills/scripts/link-skills.shpassed.jq empty pi/settings.jsonpassed.install.sh skillsrun linked every new role and the tracked settings.git diff --checkpassed.