Fix v5 folder history creation - #618
Open
GitKa3sar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V5 folder creation fails when Log plugin validates folder history
This pull request is a (multiple allowed):
Checklist
User story
Given that encrypted metadata is enabled and the Log plugin records entity history,
when a user creates a v5 folder without a plaintext
name,then the folder and its audit history should be created successfully without storing a plaintext name.
Given a v4 folder history payload,
when the plaintext
nameis missing,then the existing validation error should still be returned.
What you did
Fixes #617.
name.folders_history.nameexplicitly nullable while preserving its 256-character limit.Model.afterSave,ActionLogsModelListener, detailed folder history, andentities_history.Verification
FoldersHistoryTableTest: 4 tests, 8 assertions.EntitiesHistoryCreateServiceTest: 2 tests, 7 assertions.MetadataFoldersCreateControllerTest: 15 tests, 101 assertions.