Repository navigation
Conversation
git prints file names as UTF-8, but km decoded its output with the system's preferred encoding. On Windows that is usually cp1252, so a tracked file with a non-ASCII name came back mangled and did not exist: - km validate over the whole repo stopped with FileNotFoundError before checking anything; - km gen-index, demote and serve, which skip names that are not files, silently left the doc out: gen-index said "up to date" while the doc was missing from its list. Every git call now goes through one helper, paths.git(), that reads its output as UTF-8, and validate lists files through common.tracked_md() instead of three copies of the git call; that also stops a tracked doc deleted but not yet staged from crashing it. promote reads its child validator with PYTHONIOENCODING=utf-8, and km's console output escapes a character the console encoding lacks instead of crashing. The same platform wrote CRLF: every file km writes now gets LF, so a generated _index.md no longer shows as changed on Windows. Tests run km with EncodingWarning as an error, so any call that relies on the default encoding fails them. A test runs validate and gen-index on names with an u-umlaut and an o with double acute under an ASCII and a Latin-1 encoding. CI gains a Windows job that checks a non-ASCII name is found and that km writes LF; the release waits for it.
Owner
Author
|
Confirmed: the windows job fails on the old code. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks that the Windows job of #6 fails on the old code. Closed without merging.