Repository navigation
docs(templates): describe review by pull request, not a single writer - #15
Merged
Merged
Conversation
The team templates said only the maintainer commits to main, so git history would show the maintainer and not each contributor. That is not how a team brain works: contributors open pull requests from a branch or a fork, and the maintainer rebase-merges them. A rebase merge keeps each contributor's authorship, so git history, blame and pull requests show who contributed. That record serves provenance, never per-person analysis; the author field still names who authored the knowledge. Describe the model as one merger in the CONVENTIONS, CLAUDE.md and README templates, the km init --team help text and the skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The team templates described the access model as "one writer": only the maintainer commits to
main, so git history shows the maintainer and not each contributor. That is wrong. Contributors open pull requests (from a branch or a fork) and the maintainer rebase-merges them; a rebase merge keeps each contributor's authorship, so git history, blame and pull requests show who contributed. That record serves provenance, never per-person analysis.Changes (wording only, no behaviour change):
km promote.km init --teamhelp text: "one merger".skills/km/SKILL.md: same model in the team-brain init section; the fork-PR CI caveat now applies to members with read access.All four smoke tests pass locally.