Repository navigation
fix: corrected negative time options and cancle decompression on limit - #916
Merged
Merged
Conversation
Author
|
woah that was fast |
Author
|
mb should have added a regression check, thanks mate |
Author
|
thanks |
Owner
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am the author of lacewing and antlion, and I noticed a few minor stuff that needed fixing relating to input and cancellation, and was worth moving upstream (was working on a v3 for my libraries that corrects some implicit behaviours). Thanks for building this library :>
The first change is to
clockToleranceto fix it from accepting negative valuesThe second change was to properly close the stream in
transformby adding the missing cancellationThe third change is to correct the issue where negative values in the Remote JWKS were accepted (which actually makes the resolve refetch I think, I doubt people can use this in a DoS attack or anything but this is something worth noting)
Have a nice day.