You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: satisfy clippy lints added in Rust 1.99 - #302
CI moved to Rust 1.99, whose clippy fails the Lint job on main and on every open PR (#290, #291, #296, #300, #301).
assert_is_empty (26 test asserts): assert_eq! against an empty value. Clippy's suggested [] as [T; 0] trips the workspace as_conversions lint, so these compare to Vec::<T>::new().
approx_constant: FOUR_BIT_CENTROIDS are Lloyd-Max Gaussian centroids; the +-1.6180 entry only coincides with the golden ratio, so it is allowed with a comment.
suboptimal_flops: mul_add in the YaRN frequency blend (DeepSeek-V2, yarn.rs) and the TUI duration formatter. Fused multiply-add, so results can differ in the last bit only.
cmd_stop returns 0 once after the match instead of in every arm.
Rust 1.99's clippy fails CI Lint on main and every open PR:
- assert_is_empty: rewrite emptiness asserts as assert_eq! against an
empty value so failures show the actual contents. Clippy's suggested
`[] as [T; 0]` trips the workspace as_conversions lint, so compare to
Vec::<T>::new() instead.
- approx_constant: the 4-bit TurboQuant table holds Lloyd-Max Gaussian
centroids; +-1.6180 only coincides with the golden ratio, so allow it.
- suboptimal_flops: use mul_add in the YaRN frequency blend and TUI
duration formatting.
- match_same_arms tail: cmd_stop returns 0 once after the match.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The pull request updates test assertions to compare expected empty values directly, uses fused multiply-add in several calculations, clarifies a quantization-centroid comment and lint allowance, and moves cmd_stop’s success return after its match.
Tests now compare empty strings, vectors, and JSON arrays directly with expected values. The tested inputs and expected results remain unchanged.
Numerical Calculation Updates
Layer / File(s)
Summary
Update numerical expressions and centroid annotation crates/higgs-models/src/deepseek_v2.rs, crates/higgs-models/src/yarn.rs, crates/higgs-models/src/turboquant.rs, crates/higgs/src/tui/views/mod.rs
Three calculations use fused multiply-add. The centroid declaration now has a comment identifying the values and a local clippy::approx_constant allowance.
Daemon Stop Return
Layer / File(s)
Summary
Return success after stop outcomes crates/higgs/src/daemon.rs
cmd_stop returns 0 after the match. Existing stop handling and messages remain in place.
The PR contains lint-driven assertion and numerical updates with no identified behavior or availability risk.
Pre-merge checks: 4 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix: satisfy clippy lints added in Rust 1.99" matches the main change. The PR updates empty-value assertions, adds a local clippy allow for a centroid table, and uses mul_add in YaRN and TU…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix: satisfy clippy lints added in Rust 1.99" matches the main change. The PR updates empty-value assertions, adds a local clippy allow for a centroid table, and uses mul_add in YaRN and TUI duration formatting, all to clear clippy failures after the Rust 1.99 CI move. The title is specific and short, and it does not name every file, which is acceptable.
Full details: Docstring Coverage
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 17 files. (1 skipped: 1 too large.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
CI moved to Rust 1.99, whose clippy fails the Lint job on main and on every open PR (#290, #291, #296, #300, #301).
assert_is_empty(26 test asserts):assert_eq!against an empty value. Clippy's suggested[] as [T; 0]trips the workspaceas_conversionslint, so these compare toVec::<T>::new().approx_constant:FOUR_BIT_CENTROIDSare Lloyd-Max Gaussian centroids; the +-1.6180 entry only coincides with the golden ratio, so it is allowed with a comment.suboptimal_flops:mul_addin the YaRN frequency blend (DeepSeek-V2, yarn.rs) and the TUI duration formatter. Fused multiply-add, so results can differ in the last bit only.cmd_stopreturns0once after the match instead of in every arm.Validation (Rust 1.99.1)
cargo clippy --all-targets --all-features: cleancargo fmt --all -- --check: cleancargo test -p higgs -p higgs-engine -p higgs-models -- --test-threads=1: 1384 passed, 0 failed🤖 Generated with Claude Code
Summary by CodeRabbit