Fix prefetch failure on affinity group list

[david-crespo]

#2616 (comment)

https://oxide.sys.rack2.eng.oxide.computer/projects/product-assurance/affinity fails on prefetch invariant violation because there are 6 affinity groups, and I had the brilliant idea to only await the prefetch on the instance list for each group if there are less than 6 groups. The conditional await meant the query had to be a useQuery to not blow up when it doesn't await. It was a useQuery originally but, incredibly, it had a TODO: break me! comment on it:

console/app/pages/project/affinity/AffinityPage.tsx

Lines 139 to 146 in 7bb2f16

	// TODO: Use the prefetched query
	export const AffinityGroupMembersCell = ({
	antiAffinityGroup,
	}: {
	antiAffinityGroup: string
	}) => {
	const { project } = useProjectSelector()
	const { data: members } = useQuery(memberList({ antiAffinityGroup, project }))

So eventually we did in fact break it. The conditional logic in the loader is silly, so here we just drop it and put a correct comment on the useQuery (which is still needed because we are prefetching those calls but not awaiting them). And because we don't have the conditional, switching to a usePrefetchedQuery will now blow up the tests immediately regardless of the number of groups on the page.

The effect on the user is that the instance counts here will always have a loading skeleton, even when there are only a few groups. But that's completely fine.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
console	Ready	Preview	Jul 3, 2026 12:59pm