feat(account): show the company information modal on an invalid SIRET - #23175
Draft
AlexisAfonso wants to merge 1 commit into
Draft
feat(account): show the company information modal on an invalid SIRET#23175AlexisAfonso wants to merge 1 commit into
AlexisAfonso wants to merge 1 commit into
Conversation
The modal only reached FR corporations the API had already flagged with an e-invoicing certificate. FR B2B/B2G accounts — corporation, association or administration, in FR and the DROM — whose SIRET is missing or fails its Luhn checksum now get it too: there is nothing to bill them electronically with, so they have to fill it in. getContentKeyPrefix replaces isConcernedByAccountToReview and picks between the three wordings, a certificate always taking precedence over the SIRET check. The new "siret" variant lands in the 8 locales. Also carries a temporary debug change in new-account-form-controller.js that appends TEST to the e-invoicing address so PUT /me rejects it, to exercise the stale-address path against the real API. It is marked DO NOT COMMIT in place and has to go before review. ref: #MANAGER-22233 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Alexis AFONSO <alexis.afonso@ovhcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The modal only reached FR corporations the API had already flagged with an e-invoicing certificate. FR B2B/B2G accounts — corporation, association or administration, in FR and the DROM — whose SIRET is missing or fails its Luhn checksum now get it too: there is nothing to bill them electronically with, so they have to fill it in.
getContentKeyPrefix replaces isConcernedByAccountToReview and picks between the three wordings, a certificate always taking precedence over the SIRET check. The new "siret" variant lands in the 8 locales.
Also carries a temporary debug change in new-account-form-controller.js that appends TEST to the e-invoicing address so PUT /me rejects it, to exercise the stale-address path against the real API. It is marked DO NOT COMMIT in place and has to go before review.
Ticket Reference: #MANAGER-22233
Additional Information