Skip to content

Reject synchronous batch callback failures - #84

Merged
mcg-web merged 2 commits into
overblog:masterfrom
simPod:fix/synchronous-batch-throw
Aug 18, 2026
Merged

mcg-web merged 2 commits into
overblog:masterfrom
simPod:fix/synchronous-batch-throw

Conversation

@simPod

@simPod simPod commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Convert synchronous batch callback throws into rejected load promises.
  • Reject every queued load through the existing whole-batch failure path.
  • Cache promises before immediate dispatch so failed non-batched loads can retry.

Motivation

A callback that throws before returning a promise escapes dispatch and can leave queued promises unresolved or cache a failed immediate load. The current master Throwable contract handles both Exception and Error consistently.

@mcg-web
mcg-web merged commit 9506c0d into overblog:master Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants