Update osac repo's required status check for CaaS Netris rename - #166
Merged
eliorerz merged 1 commit intoAug 5, 2026
Merged
Conversation
osac-project/osac#110 replaced e2e-caas-full-install.yml with e2e-caas-netris-full-install.yml, so the "e2e-caas-full-install / e2e" required check will never report again -- blocking every future PR on osac's branch protection forever. Point the required check at the new workflow's gating job instead. Signed-off-by: Elior Erez <eerez@redhat.com>
WalkthroughThe Changesrepo_osac status check
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@repositories.tf`:
- Line 150: Add a Red Hat AI attribution trailer to the commit message for the
change near the e2e-caas-netris-full-install integration entry, using either an
Assisted-by or Generated-by trailer; do not use a Co-Authored-By trailer for
this attribution.
- Line 150: Update the repository configuration entry’s context value to exactly
“E2E CaaS Netris Full Install / e2e” while preserving integration_id = 15368.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 620826de-9300-4c6a-b8bc-b6fa0c9ccf20
📒 Files selected for processing (1)
repositories.tf
| { context = "e2e-vmaas-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-bmaas-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-caas-full-install / e2e", integration_id = 15368 }, | ||
| { context = "e2e-caas-netris-full-install / e2e", integration_id = 15368 }, |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
message="$(git log -1 --format=%B)"
printf '%s\n' "$message"
grep -Eiq '^(Assisted-by|Generated-by):.*Red Hat' <<<"$message" ||
{ echo "Missing Red Hat Assisted-by or Generated-by trailer" >&2; exit 1; }
if grep -Eiq '^Co-Authored-By:.*(AI|GPT|Claude|Copilot|bot)' <<<"$message"; then
echo "AI tool must not appear in Co-Authored-By" >&2
exit 1
fiRepository: osac-project/github-config
Length of output: 631
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Commit:"
git show -s --format='%H%n%P%n%s' HEAD
echo
echo "Parsed trailers:"
git show -s --format='%B' HEAD | git interpret-trailers --parse || true
echo
echo "Full commit message:"
git show -s --format='%B' HEADRepository: osac-project/github-config
Length of output: 819
Add the required AI attribution trailer.
The commit message lacks a Red Hat Assisted-by or Generated-by trailer. No AI tool appears in a Co-Authored-By trailer.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@repositories.tf` at line 150, Add a Red Hat AI attribution trailer to the
commit message for the change near the e2e-caas-netris-full-install integration
entry, using either an Assisted-by or Generated-by trailer; do not use a
Co-Authored-By trailer for this attribution.
Source: Coding guidelines
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n --hidden --glob '!.git/**' \
'e2e-caas-netris-full-install|e2e-caas-full-install|^\s*(name|e2e):' .Repository: osac-project/github-config
Length of output: 432
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- repositories.tf context ---'
sed -n '135,160p' repositories.tf
printf '%s\n' '--- workflow files ---'
git ls-files '.github/workflows/*' | while IFS= read -r file; do
printf '\n### %s\n' "$file"
sed -n '1,220p' "$file"
done
printf '%s\n' '--- relevant references ---'
rg -n --hidden --glob '!.git/**' \
'15368|e2e-caas-netris-full-install|e2e-caas-full-install|repo_osac|Assisted-by|Generated-by|Co-Authored-By' .
printf '%s\n' '--- recent commit trailers ---'
git log -8 --format='%H%n%s%n%(trailers:key=Assisted-by,only)%n%(trailers:key=Generated-by,only)%n%(trailers:key=Co-Authored-By,only)%n---'Repository: osac-project/github-config
Length of output: 6702
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- change introducing the context ---'
git show --format=fuller --stat --oneline 6969e69068961fb0c253b15c0182c6cef3956d8c
git show --format= --no-ext-diff 6969e69068961fb0c253b15c0182c6cef3956d8c -- repositories.tf
printf '%s\n' '--- repository remotes ---'
git remote -v
printf '%s\n' '--- public osac workflow definitions ---'
curl -fsSL https://api.github.com/repos/osac-project/osac/actions/workflows \
| jq -r '.workflows[] | [.name, .path, .state] | `@tsv`' \
| grep -E 'e2e|install|workflow' || true
printf '%s\n' '--- matching workflow content ---'
for path in \
.github/workflows/e2e-caas-netris-full-install.yaml \
.github/workflows/e2e-caas-netris-full-install.yml \
.github/workflows/e2e-caas-full-install.yaml \
.github/workflows/e2e-caas-full-install.yml
do
url="https://raw.githubusercontent.com/osac-project/osac/main/$path"
if content=$(curl -fsSL "$url" 2>/dev/null); then
printf '\n### %s\n' "$path"
printf '%s\n' "$content" | sed -n '1,180p'
fi
doneRepository: osac-project/github-config
Length of output: 5089
Use the workflow’s exact check context. The workflow emits E2E CaaS Netris Full Install / e2e, not e2e-caas-netris-full-install / e2e. Update context and retain integration_id = 15368.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@repositories.tf` at line 150, Update the repository configuration entry’s
context value to exactly “E2E CaaS Netris Full Install / e2e” while preserving
integration_id = 15368.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
osac-project/osac#110 (merged 2026-08-05) deleted
e2e-caas-full-install.ymland replaced it withe2e-caas-netris-full-install.yml, but this repo's branch protection forosacstill requires the old check name (e2e-caas-full-install / e2e). That check will never report again, which would permanently block every future PR onosac's ruleset (short of an admin bypass).What
Points the required status check at the new workflow's gating job (
e2e-caas-netris-full-install / e2e) — same<workflow-basename> / e2epattern already used for the vmaas/bmaas entries.Summary by CodeRabbit