Repository navigation
feat: Bark expansion - #51
Merged
Merged
Conversation
- Add an authored `payment_methods` set (bolt11, onchain, arkoor; default all, as upstream) to cdk-bark-processor; renderer, driver and readiness use it, and CDK 0.18.1 mints bind each advertised method - Model payment methods and units as open Cashu strings, so custom methods such as arkoor and custom units need no enum - Extend the managed Bark gate to check method registration and an on-chain deposit, and regenerate schemas, CRDs, coverage and goldens
- Render each CDK payment section's unit from its payment-link bindings, with a new `embedded_lightning_unit` for LDK Node; BDK stays sat, as upstream requires - Validate one unit per backend and check embedded tuples against the catalog at lock time; the catalog still lists only sat - Rename CDK Lightning limits to unit-neutral `min_mint`/`max_mint`/`min_melt`/`max_melt` and regenerate schemas, coverage and goldens
Update the workspace crates, Cargo.lock, Helm chart, install script and tools/versions.env from 0.1.0-alpha.8 to 0.1.0-alpha.9 for the release.
The on-chain stage POSTed its quote through a new port-forward before it was listening, so curl was refused after 0 ms on both architectures. Warm the forward with a retrying /v1/info read first, as the recovery stage does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
cdk-bark-processorgainspayment_methods(bolt11,onchain,arkoor); the default advertises all three, as upstream does.embedded_lightning_unitfor LDK Node.Changes
Important
Existing Bark cells with only a
bolt11binding no longer validate. Addonchainandarkoorbindings, or setpayment_methods: ["bolt11"]on the processor. Recreate affected cells.min_mint_sat,max_mint_sat,min_melt_satandmax_melt_satare nowmin_mint,max_mint,min_meltandmax_melt.Important
Update authored CDK mint configs to the new names. On-chain (
onchain_*_sat) and Nutshell limits are unchanged.arkoorneed no code change.GetSettingsmust report exactly the configured methods, and startup refuses a missing method list.0.1.0-alpha.9.Note
The catalog still admits only
sat. msat for LND, CLN and LDK Node needs its own qualification gate first.Testing
Note
The new Bark gate stages run for the first time in this PR's CI. arkoor payments and on-chain melts are not exercised.