Skip to content

change maps flags from hyphen to underscore in definition files#120

Merged
elfkuzco merged 1 commit into
mainfrom
fix-maps-definitions
Jun 15, 2026
Merged

change maps flags from hyphen to underscore in definition files#120
elfkuzco merged 1 commit into
mainfrom
fix-maps-definitions

Conversation

@elfkuzco

Copy link
Copy Markdown
Contributor

Changes

  • change hypens to underscores in maps offliner definition files. Since the underlying model is DashModel, they would be converted to hyphens while generating the commands for the tasks in zimfarm

@elfkuzco elfkuzco self-assigned this Jun 15, 2026
@elfkuzco elfkuzco requested a review from benoit74 June 15, 2026 09:06
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.88%. Comparing base (305c871) to head (4c60944).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   35.88%   35.88%           
=======================================
  Files          11       11           
  Lines        1045     1045           
  Branches      153      153           
=======================================
  Hits          375      375           
  Misses        654      654           
  Partials       16       16           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing bad code I've pushed ^^

@elfkuzco elfkuzco merged commit 829fd23 into main Jun 15, 2026
10 checks passed
@elfkuzco elfkuzco deleted the fix-maps-definitions branch June 15, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants