Skip to content

vdev_rebuild: wait for the syncing txg before rebuilding a metaslab #19198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behlendorf merged 1 commit into from
Oct 15, 2026
Merged

vdev_rebuild: wait for the syncing txg before rebuilding a metaslab #19198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions module/zfs/vdev_rebuild.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,14 +835,17 @@ vdev_rebuild_thread(void *arg)
spa_config_exit(spa, SCL_CONFIG, FTAG);
metaslab_disable(msp);

/*
* Wait for remaining sync passes and outstanding allocations
* so all allocated ranges are on disk before rebuilding them.
* Later sync passes can rewrite blocks in place without
* allocating, so waiting for allocations alone is insufficient.
*/
txg_wait_synced(dp, spa_syncing_txg(spa));

mutex_enter(&msp->ms_sync_lock);
mutex_enter(&msp->ms_lock);

/*
* If there are outstanding allocations wait for them to be
* synced. This is needed to ensure all allocated ranges are
* on disk and therefore will be rebuilt.
*/
for (int j = 0; j < TXG_SIZE; j++) {
if (zfs_range_tree_space(msp->ms_allocating[j])) {
mutex_exit(&msp->ms_lock);
Expand Down
Loading