Repository navigation
Conversation
openwrt/packages#31261 is open and ready for review; openwrt/luci#9243 is open as a draft until the package PR merges. Record the formality results, the stop-path LAN tests and the updated branch names. Signed-off-by: Amr Fateem <amr.fateem@yahoo.com>
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
- cb7ab75 "luci-app-v2raya: add overview and richer settings" — the commit also adds the author to
PKG_MAINTAINER/LUCI_MAINTAINER, and the message does not mention it; add a line about it or split it into its own commit.
Generated by Claude Code
| "/usr/bin/v2raya": [ "exec" ], | ||
| "/usr/bin/v2raya_core": [ "exec" ], |
There was a problem hiding this comment.
A bare path grants exec with any arguments (rpcd checks the executable alone first at file.c:1065), so read-only users could launch a root v2raya / v2raya_core run -c ... instance. Pin the exact command lines the overview uses, as the init-script entries below already do.
| "/usr/bin/v2raya": [ "exec" ], | |
| "/usr/bin/v2raya_core": [ "exec" ], | |
| "/usr/bin/v2raya --version": [ "exec" ], | |
| "/usr/bin/v2raya_core version": [ "exec" ], |
Generated by Claude Code
| return L.resolveDefault(uci.save(), null).then(function () { | ||
| /* Commit before starting: the init script reads enabled from UCI. */ | ||
| return L.resolveDefault(uci.apply(), null); |
There was a problem hiding this comment.
uci.apply() commits every change staged in the session for all configs, not just v2raya.config.enabled, and both resolveDefault wrappers hide a failed save/apply so start then runs against enabled=0. Commit only this option on the backend (see the [ensureEnabled approach in luci-app-weechat status.js:69](https://github.com/openwrt/luci/blob/cb7ab7509ed55d13d7fa99a3d8c015a4afce643b/applications/luci-app-weechat/htdocs/luci-static/resources/view/weechat/status.js#L69-L91)) and surface the error instead of swallowing it.
Generated by Claude Code
| }; | ||
| o.description = _('The web interface listens on this address. Use 127.0.0.1:2017 to keep it off the LAN.'); | ||
|
|
||
| o = s.taboption('general', form.Value, 'baseurl', _('Base URL')); |
There was a problem hiding this comment.
baseurl, core_startup_timeout, redirect_respect_bound_device, v2ray_assetsdir, gomemlimit, gomaxprocs, gogc and nofile are not read by the current v2raya init script, so with 2.2.x they silently do nothing even though the commit says the app still works there. The body says this waits on openwrt/packages#31261, but the PR is not marked draft — should it be, or should these options be hidden when the backend lacks them?
Generated by Claude Code
| _('Unit: days.')); | ||
| o = s.taboption('advanced', form.Value, 'v2ray_assetsdir', _('Rule data directory')); | ||
| o.placeholder = '/usr/share/v2ray'; | ||
| o.default = '/usr/share/v2ray'; |
There was a problem hiding this comment.
The description says "Leave empty for auto-detection", but this default pre-fills the field and writes /usr/share/v2ray on the next save, so auto-detection never applies. Drop the default and keep only the placeholder.
| o.default = '/usr/share/v2ray'; |
Generated by Claude Code
Replace the single settings form with three pages: an overview with the service state, versions, detected cores and start/stop controls; a tabbed settings form for the options the 2.5.x init script supports; and a log viewer with refresh and clear. The overview reads /usr/libexec/v2raya-detect, which the v2raya package installs, to report the installed core and any other proxy service. Detection is skipped cleanly when the helper is absent, so the page also works with the older 2.2.x package. Pin the exact version commands in the ACL, and use a small helper that commits only v2raya.config.enabled before starting the service. Add Amr Fateem to LUCI_MAINTAINER and PKG_MAINTAINER. Signed-off-by: Amr Fateem <amr.fateem@yahoo.com>
cb7ab75 to
844ed28
Compare
|
Bot for @amrfateem: all openwrt-ai items are addressed in 844ed28:
The PR is draft until openwrt/packages#31261 merges. |
|
Bot for @amrfateem: Test Build, ESLint and CodeQL are waiting for maintainer approval. @1715173329 could you approve them when you review? |
|
NAK. package changes are rejected already. |
|
Understood. sorry for that. same question as the other one. If I make better on the PR. should I create a new one instead or add the comments here ? |
Pull request details
Description
Replace the minimal v2rayA configuration form with three pages:
The overview uses /usr/libexec/v2raya-detect; it degrades cleanly when the helper is absent. The ACL pins the exact version commands, and a small helper commits only v2raya.config.enabled before start.
AI assistance: prepared by an automated agent for @amrfateem; the human maintainer reviewed the code and takes responsibility.
Maintainer
@1715173329 @amrfateem
Tested on
OpenWrt version: 25.12-SNAPSHOT r0-2d44c5a
LuCI version: 26.304.26398~e969939
Web browser(s): Chromium-based browser
Checklist
openwrt/packages#31261)Draft until
openwrt/packages#31261merges.