Repository navigation
luci-mod-network: add WiFi 7 (802.11be / EHT) advanced configuration options - #8461
prokowsoftware wants to merge 1 commit into
Conversation
Is this for client mode? |
No, disable_eht here is for AP mode only. In a typical deployment, the AP advertises its capabilities via beacons and the client adapts accordingly — so disabling EHT on the AP side is sufficient to fall back to 802.11ax (HE). disable_eht is also supported by wpa_supplicant (client mode), but that use case is niche — it would only be needed if you want a station to avoid EHT even when the AP offers it (e.g. for debugging or compatibility testing). We didn't include it here as it's outside the scope of this PR. |
Okay so what's the point of this option? |
|
Good question. The difference is subtle but useful in practice: When you set htmode to an HE (WiFi 6) mode, you reconfigure the entire radio — channel width, beamforming, everything — for 802.11ax. disable_eht lets you keep your EHT channel configuration (e.g. EHT320) but disable the 802.11be-specific features, so the AP falls back to HE for client associations. This is useful for:
If you want to permanently run in WiFi 6 mode, yes — just select an HE htmode. disable_eht is more of a diagnostic/transitional toggle. |
|
To be honest, the main motivation for this PR was sae_pwe. We were unable to properly configure our AP with WPA3/SAE — clients kept failing to associate — until we set sae_pwe=2 (H&P + H2E). Without this option exposed in the UI, it required manual UCI editing every time. The EHT options came along naturally as we were already working with WiFi 7 hardware (QCN9274) and the wireless configuration page. |
|
We are also waiting for a newer kernel in OpenWrt (6.12+) to properly support MLO (Multi-Link Operation). Once that lands in a stable release, we plan to extend this with MLO configuration options as well. |
320MHz is EHT only.
Which version of OpenWrt are you using? |
|
And the additional options are available in the wifi scripts? |
|
@prokowsoftware: Nice work, thanks! Have you seen recent @castiel652 and @systemcrash comments? |
|
Thanks for the review, @castiel652 and @systemcrash!
You're correct, and thank you for the correction. 320 MHz channel width is defined exclusively in IEEE 802.11be (EHT) - there is no 802.11ax (HE) equivalent. Using The realistic use cases for
Even if hostapd's compiled-in default is correct, the option was not exposed in the LuCI UI - so users had no way to see what value was in effect or change it without manual UCI editing. In our specific case (OpenWrt 24.10, QCN9274, 6 GHz), client associations were failing with WPA3/SAE until we explicitly set This PR targets OpenWrt 24.10, where the EHT htmodes were introduced in #7302.
Yes - all five options map to hostapd configuration keys that are handled by OpenWrt's
We tested |
Use HE80/HE160?????
You should check the hostapd conf file
No. This PR targets master branch. Check again.
Are you sure about the first four options? |
|
Is this for 24.10 only? ( meaning that 25.12 works fine? ) |
|
@systemcrash @castiel652 — thanks for the continued discussion! To answer your question directly: we're planning to test the latest OpenWrt (25.x) this week. Our changes were developed and tested against 24.10.2, so we haven't yet verified whether they're required on the latest tree or whether some of the issues we encountered (particularly the sae_pwe default and EHT-related UI behavior) are already addressed there. We'll report back once we've had a chance to run through it on current master. |
|
If this works against 25.12 and master (where it should always be tested first) then it can go in. |
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; 1 inline issue found (frontend-only EHT options with no backend consumer on master).
Generated by Claude Code
| o = ss.taboption('advanced', form.Flag, 'disable_eht', _('Disable EHT (802.11be)'), _('Disable IEEE 802.11be (WiFi 7 / EHT) operation and fall back to 802.11ax (WiFi 6 / HE).')); | ||
| o.rmempty = true; | ||
|
|
||
| o = ss.taboption('advanced', form.Value, 'punct_bitmap', _('Punctured Channel Bitmap'), _('Bitmask of 20 MHz sub-channels to exclude (puncture) in the operating channel. Each bit represents one 20 MHz sub-channel; setting a bit to 1 disables that sub-channel. Applies only to EHT160 and EHT320 modes.')); | ||
| o.datatype = 'range(0,65535)'; | ||
| o.placeholder = '0'; | ||
| o.rmempty = true; | ||
| o.depends('htmode', 'EHT160'); | ||
| o.depends('htmode', 'EHT320'); | ||
|
|
||
| o = ss.taboption('advanced', form.Flag, 'eht_su_beamformer', _('EHT SU Beamformer'), _('Enable IEEE 802.11be (WiFi 7) Single-User Transmit Beamformer capability.')); | ||
| o.default = '1'; | ||
| o.rmempty = true; | ||
|
|
||
| o = ss.taboption('advanced', form.Flag, 'eht_mu_beamformer', _('EHT MU Beamformer'), _('Enable IEEE 802.11be (WiFi 7) Multi-User Transmit Beamformer capability.')); | ||
| o.default = '1'; | ||
| o.rmempty = true; | ||
| } |
There was a problem hiding this comment.
Frontend-only options with no backend consumer on master. None of disable_eht, punct_bitmap, eht_su_beamformer, or eht_mu_beamformer are read by the wifi-scripts in openwrt/openwrt. The ucode hostapd generator passes options through an explicit allow-list, and the EHT branch only forwards ieee80211be / eht_oper_chwidth / eht_oper_centr_freq_seg0_idx: https://github.com/openwrt/openwrt/blob/f37476a856ee67e75e3b9c9a24b6ba97350e26bc/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/hostapd.uc#L450-L457 — the four names above appear nowhere in files-ucode/ or in the legacy files/lib/netifd/hostapd.sh, and there are no matching entries in wireless.wifi-device.json. As written, setting these in the UI will silently do nothing on current master.
For contrast, the HE equivalents he_su_beamformer / he_mu_beamformer are both declared in the device schema and explicitly appended in the HE branch (hostapd.uc L436), which is the pattern these new EHT options would need to follow on the backend side.
The PR body states these map to hostapd keys "in 24.10", but per the discussion thread the change must work against master/25.x. Either the corresponding openwrt/openwrt wifi-scripts support needs to land first (and be referenced here as a dependency), or these four options should be dropped from this PR. sae_pwe is unaffected — it is genuinely consumed. Which daemon/script is expected to read these four on master?
Generated by Claude Code
d01628d to
a5f493f
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The head commit is a rebase of the previously reviewed commit onto a newer base with identical file contents (no code changes since the last review).
Generated by Claude Code
a5f493f to
b6408be
Compare
| o.depends('encryption', 'sae'); | ||
| o.depends('encryption', 'sae-mixed'); |
There was a problem hiding this comment.
sae-compat is missing here: the backend applies sae_pwe to psk-sae-compat too (ap.uc:116-124),`` and the neighbouring SAE options (gcmp256, `sae_ext_key`) already list it.
| o.depends('encryption', 'sae'); | |
| o.depends('encryption', 'sae-mixed'); | |
| o.depends('encryption', 'sae'); | |
| o.depends('encryption', 'sae-mixed'); | |
| o.depends('encryption', 'sae-compat'); |
Generated by Claude Code
| o.value('0', _('Hunting-and-Pecking (H&P) only')); | ||
| o.value('1', _('Hash-to-Element (H2E) only')); | ||
| o.value('2', _('H&P and H2E (recommended for WiFi 7 / 6 GHz)')); | ||
| o.default = '2'; |
There was a problem hiding this comment.
A ListValue with default = '2' writes sae_pwe=2 on the next save, which overrides the backend's band-dependent default of 1 (H2E only) on 6 GHz (ap.uc:119-123)`` and the PPSK exemption. Add an empty "automatic" entry and make it the default, so nothing gets written unless the user picks a value.
Generated by Claude Code
…options Add advanced wireless configuration options for IEEE 802.11be (WiFi 7 / EHT) to the network wireless view: - disable_eht: allow falling back to 802.11ax (HE) operation - punct_bitmap: preamble puncturing bitmap for EHT160/EHT320 modes - eht_su_beamformer / eht_mu_beamformer: SU/MU transmit beamformer capabilities - sae_pwe: SAE password element derivation mechanism (H&P / H2E), with H2E required for WiFi 7 (802.11be) on the 6 GHz band These map to the corresponding hostapd options and are exposed under the advanced and encryption tabs of the wireless configuration. Signed-off-by: Daniel Meyer <prokowsoftware@gmail.com>
b6408be to
7e3bece
Compare
|
Thanks everyone for the review. An honest status update: This work was developed and tested against 24.10.2 on a Radxa board with a QCN9274 (802.11be) radio. The project it was part of has since been cancelled and we've had to return the hardware, so I can no longer verify the options against master / 25.12 as @systemcrash asked. The formality check is now fixed — author and Signed-off-by use a real address. I don't want to block this indefinitely. If someone with WiFi 7 hardware is able to confirm the backend wiring ( |
Summary
PR #7302 (merged Oct 2024) added basic 802.11be mode selection (EHT htmodes) but did not expose advanced EHT-specific configuration options in the UI. This PR adds the missing options.
New options in the Advanced tab (radio device):
disable_eht) — fall back to 802.11ax (WiFi 6 / HE)punct_bitmap) — bitmask of 20 MHz sub-channels to exclude; shown only for EHT160 and EHT320 modeseht_su_beamformer) — enable Single-User Transmit Beamformer capabilityeht_mu_beamformer) — enable Multi-User Transmit Beamformer capabilityNew option in the Wireless Security tab (interface):
sae_pwe) — selects the mechanism for SAE password element derivation (H&P, H2E, or both); H2E is required for WiFi 7 on 6 GHz; shown only forsaeandsae-mixedencryption modesTesting
Tested on a Radxa device with QCN9274 (802.11be) card running OpenWrt.