Skip to content

test(ers): wait for seeded LDAP readiness - #3841

Open
jrschumacher wants to merge 5 commits into
mainfrom
test/ers-ldap-readiness
Open

test(ers): wait for seeded LDAP readiness#3841
jrschumacher wants to merge 5 commits into
mainfrom
test/ers-ldap-readiness

Conversation

@jrschumacher

Copy link
Copy Markdown
Member

Summary

  • replace the OpenLDAP startup-log wait with a bounded semantic readiness check
  • wait for port 389 and repeatedly query LDAP until the seeded Alice DN is present
  • document the pinned image dependency on the bundled ldapsearch client

Why

The token-based ERS BDD scenarios depend on seeded LDAP users. The existing slapd starting log only proves the daemon started; it can fire before custom LDIF fixtures are queryable, allowing the scenario to race bootstrap and fail for the wrong reason.

Testing

  • cd tests-bdd && go test ./cukes -run "^$" -count=1
  • cd tests-bdd && golangci-lint run --disable nestif ./cukes

Stack

Stacked above #3836 so the existing ERS PRs can merge independently.

@jrschumacher
jrschumacher requested a review from a team as a code owner August 6, 2026 01:40
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 14d703e1-ee97-48dc-888e-682f7ad2acdb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/s label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 97.751399ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 56.164814ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 247.86707ms
Throughput 403.44 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 29.354918098s
Average Latency 292.121768ms
Throughput 170.33 requests/second

Base automatically changed from fix/3794-review-followups to test-3801-provider-contract-matrix August 7, 2026 09:22
@jrschumacher
jrschumacher force-pushed the test-3801-provider-contract-matrix branch 2 times, most recently from 8f2b39c to 3ad335e Compare August 7, 2026 14:33
@jrschumacher
jrschumacher force-pushed the test/ers-ldap-readiness branch from 922fae7 to e7b354a Compare August 7, 2026 14:33
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 209.466156ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 114.245104ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 418.365874ms
Throughput 239.03 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 43.198809798s
Average Latency 431.229184ms
Throughput 115.74 requests/second

Signed-off-by: Ryan Schumacher <jschumacher@virtru.com>
Signed-off-by: Ryan Schumacher <jschumacher@virtru.com>
Signed-off-by: Ryan Schumacher <jschumacher@virtru.com>
Signed-off-by: Ryan Schumacher <jschumacher@virtru.com>
@jrschumacher
jrschumacher force-pushed the test-3801-provider-contract-matrix branch from 3ad335e to 342e5b3 Compare August 7, 2026 14:59
@jrschumacher
jrschumacher requested a review from a team as a code owner August 7, 2026 14:59
Signed-off-by: Ryan Schumacher <jschumacher@virtru.com>
@jrschumacher
jrschumacher force-pushed the test/ers-ldap-readiness branch from e7b354a to e40aa62 Compare August 7, 2026 14:59
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 189.689484ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 98.529418ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 405.626976ms
Throughput 246.53 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 42.441276507s
Average Latency 423.548768ms
Throughput 117.81 requests/second

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • examples
  • otdfctl
  • sdk
  • service
  • lib/fixtures
  • tests-bdd

See the workflow run for details.

Base automatically changed from test-3801-provider-contract-matrix to main August 7, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant