OLS-3593 enable init container comparison for app server deployment

[raptorsun]

Summary

• Fix: detect changes to .spec.ols.rag (RAG image references) so they trigger a deployment rollout
• Root cause: DeploymentSpecEqual was called with compareInitContainers=false, and no other change detector tracked RAG images — so RAG image changes were silently ignored

Why not just enable init container comparison?

The obvious fix — flipping compareInitContainers from false to true — causes an infinite reconciliation loop when RAG is configured.

When RAG images are present, the operator sets an image.openshift.io/triggers annotation on the deployment (rag.go:62-79). This tells OpenShift's image trigger controller to resolve ImageStreamTags and replace the init container image field with the resolved @sha256:... digest. With compareInitContainers=true, this creates a fight between two controllers:

1. Operator reconciles → generates desired deployment with the user-specified image tag (e.g., my-image:latest)
2. OpenShift trigger controller → resolves the tag and writes the SHA digest into the deployment (e.g., my-image@sha256:abc...)
3. Operator reconciles again → ContainerSpecEqual compares a.Image == b.Image, sees tag != digest, detects a "change"
4. Operator updates the deployment back to the tag → goto step 2

This was confirmed in e2e testing where the deployment generation reached 5663 vs observed generation 2303 (~5-6 updates/second).

Solution

Track a SHA-256 hash of the CR's .spec.ols.rag in a deployment annotation (ols.openshift.io/rag-spec-hash). When the user changes RAG image references, the hash changes and triggers a deployment rollout — without comparing init container images directly and without conflicting with OpenShift's image trigger mechanism.

Test plan

• make test passes — all unit tests green
• bundle-e2e-4-21 CI passed (including BYOK/RAG tests)
• Deploy OLS with a RAG image configured, change the image tag, and verify the operator rolls out a new deployment

Fixes: OLS-3593

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@raptorsun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4a731d03-43dc-4acc-a4a0-c37029a5718b

📥 Commits

Reviewing files that changed from the base of the PR and between d3e5e5a and 621853e.

📒 Files selected for processing (2)

• internal/controller/appserver/deployment.go
• internal/controller/utils/constants.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[raptorsun]

/retest

[openshift-ci]

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.