OLS-3515: Use Konflux :main tag for Otel and adapter, and fix OTEL config - #414
Conversation
blublinsky
commented
Aug 4, 2026
blublinsky
commented
- Switch deploy-otel.sh and deploy-alerts-adapter.sh from runtime Quay API resolution to Konflux :main defaults, matching the other quickstart images.
- Fix OTEL routing condition in deploy-otel.sh: attributes["service.name"] == "lightspeed-agentic" → resource.attributes["service.name"] == "lightspeed-agentic-sandbox" (service.name is a resource attribute, not a log record attribute).
- Update install.sh help text and README.md accordingly.
openshift-ci-robot
added
the
jira/valid-reference
|
@blublinsky: This pull request references OLS-3515 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughQuickstart deployment removes dynamic Quay image resolution. Alerts-adapter and OTEL images now default to fixed Konflux ChangesQuickstart image and routing updates
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blublinsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/quickstart/README.md`:
- Around line 93-98: Remove the obsolete python3 and curl prerequisite from the
Quickstart prerequisites near the image-resolution documentation, since images
now use Konflux’s floating :main tag and no longer require automatic Quay
resolution. Only retain the requirement if an existing script still performs
that lookup, and document that script’s continued use.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f49716dd-893f-4272-a7bc-70c706b5a7c4
📒 Files selected for processing (4)
hack/quickstart/README.mdhack/quickstart/deploy-alerts-adapter.shhack/quickstart/deploy-otel.shhack/quickstart/install.sh
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
01dce3c to
b13f22e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/quickstart/install.sh`:
- Around line 79-80: Make the openssl prerequisite check in the install script
conditional on the --postgres option, while keeping the python3 check
unconditional. Reuse the script’s existing argument-parsing state or option
variable to guard the command -v openssl validation, ensuring non-Postgres
quickstarts do not require openssl.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5a817733-1cf9-4b48-aa82-35d0b973f0db
📒 Files selected for processing (4)
hack/quickstart/README.mdhack/quickstart/deploy-alerts-adapter.shhack/quickstart/deploy-otel.shhack/quickstart/install.sh
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
🚧 Files skipped from review as they are similar to previous changes (2)
- hack/quickstart/README.md
- hack/quickstart/deploy-otel.sh
| command -v python3 >/dev/null 2>&1 || fail "python3 not found. Required by deploy scripts." | ||
| command -v openssl >/dev/null 2>&1 || fail "openssl not found. Required by deploy scripts." |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n -P '(^|[^[:alnum:]_])(curl|openssl)([^[:alnum:]_]|$)|--postgres' \
hack/quickstart --glob '*.sh'Repository: openshift/lightspeed-agentic-operator
Length of output: 1295
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '--- install.sh outline ---\n'
ast-grep outline hack/quickstart/install.sh --view expanded || true
printf '\n--- install.sh relevant lines ---\n'
sed -n '1,140p' hack/quickstart/install.sh
printf '\n--- deploy scripts ---\n'
for f in hack/quickstart/deploy-otel.sh hack/quickstart/deploy-postgres.sh; do
printf '\n### %s\n' "$f"
sed -n '1,120p' "$f"
done
printf '\n--- curl/openssl occurrences under hack/quickstart ---\n'
rg -n --word-regexp 'curl|openssl' hack/quickstart --glob '*.sh' || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 266
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- install.sh outline ---'
ast-grep outline hack/quickstart/install.sh --view expanded || true
printf '%s\n' ''
printf '%s\n' '--- install.sh relevant lines ---'
sed -n '1,140p' hack/quickstart/install.sh
printf '%s\n' ''
printf '%s\n' '--- deploy scripts ---'
for f in hack/quickstart/deploy-otel.sh hack/quickstart/deploy-postgres.sh; do
printf '%s\n' ""
printf '%s\n' "### $f"
sed -n '1,120p' "$f"
done
printf '%s\n' ''
printf '%s\n' '--- curl/openssl occurrences under hack/quickstart ---'
rg -n --word-regexp 'curl|openssl' hack/quickstart --glob '*.sh' || trueRepository: openshift/lightspeed-agentic-operator
Length of output: 13197
Make the Top-level openssl prerequisite conditional.
openssl is required only when --postgres is passed: hack/quickstart/deploy-otel.sh:54 checks it before Postgres deployment, and hack/quickstart/deploy-postgres.sh:32 uses openssl rand -base64 16. Keep this check conditional in hack/quickstart/install.sh:80, or document openssl as a global quickstart prerequisite.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@hack/quickstart/install.sh` around lines 79 - 80, Make the openssl
prerequisite check in the install script conditional on the --postgres option,
while keeping the python3 check unconditional. Reuse the script’s existing
argument-parsing state or option variable to guard the command -v openssl
validation, ensuring non-Postgres quickstarts do not require openssl.
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
3 participants
