8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP - #780
8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP#780rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
|
Going to push as commit e0bf19c.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP.
This PR fixes a regression for vectorized unsigned integer/long equality checks.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/compiler/c2/irTests/TestVectorConditionalMove.java
make test TEST=hotspot_compiler
Results:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/780/head:pull/780$ git checkout pull/780Update a local copy of the PR:
$ git checkout pull/780$ git pull https://git.openjdk.org/jdk25u-dev.git pull/780/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 780View PR using the GUI difftool:
$ git pr show -t 780Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/780.diff
Using Webrev
Link to Webrev Comment