Skip to content

8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP - #780

Closed
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8370794-V25-V2
Closed

8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP#780
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8370794-V25-V2

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP.

This PR fixes a regression for vectorized unsigned integer/long equality checks.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/c2/irTests/TestVectorConditionalMove.java
make test TEST=hotspot_compiler

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370794 needs maintainer approval

Issue

  • JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/780/head:pull/780
$ git checkout pull/780

Update a local copy of the PR:
$ git checkout pull/780
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 780

View PR using the GUI difftool:
$ git pr show -t 780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/780.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review September 4, 2026 12:45
@bridgekeeper

bridgekeeper Bot commented Sep 4, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Sep 4, 2026

Copy link
Copy Markdown

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP

You can use pull request commands such as /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 667744c353e4d6abbe5cbf85746e5e0e44dafaf8 8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP Sep 4, 2026
@openjdk

openjdk Bot commented Sep 4, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2026
@mlbridge

mlbridge Bot commented Sep 4, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Sep 4, 2026

Copy link
Copy Markdown

Going to push as commit e0bf19c.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Sep 4, 2026
@openjdk openjdk Bot closed this Sep 4, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2026
@openjdk

openjdk Bot commented Sep 4, 2026

Copy link
Copy Markdown

@rm-gh-8 Pushed as commit e0bf19c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant