8387907: Shenandoah: Marking loop prefetch - #746
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Dramatically improves Shenandoah marking performance. Applies cleanly. Tests pass, performance improves at the same level as in mainline. Risk is medium-low: simple change in production paths, isolated to Shenandoah, no bugtail since 6 weeks in mainline. |
|
Push approval granted. /integrate |
|
Going to push as commit b4b9425.
Your commit was automatically rebased without conflicts. |
Dramatically improves Shenandoah performance.
Additional testing:
hotspot_gc_shenandoahhotspot_gc_shenandoahhotspot_gc_shenandoahwith-XX:TieredStopAtLevel=1hotspot_gc_shenandoahwith-XX:TieredStopAtLevel=1allwith-XX:+UseShenandoahGCallwith-XX:+UseShenandoahGCallwith-XX:+UseShenandoahGC -XX:TieredStopAtLevel=1allwith-XX:+UseShenandoahGC -XX:TieredStopAtLevel=1Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/746/head:pull/746$ git checkout pull/746Update a local copy of the PR:
$ git checkout pull/746$ git pull https://git.openjdk.org/jdk25u-dev.git pull/746/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 746View PR using the GUI difftool:
$ git pr show -t 746Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/746.diff
Using Webrev
Link to Webrev Comment