fix Zcmp extension fault handling - #3409
Open
zxz2004626 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix issue #3408 .
The SPEC 28.1.13.3. PUSH/POP Fault handling requires the entire Zcmp PUSH/POP sequence is re-executed after returning from the trap handler.
The SPEC 28.1.13.7. cm.push, SPEC 28.1.13.8. cm.pop, SPEC 28.1.13.9. cm.popretz, SPEC 28.1.13.10. cm.popret statements
"The final section of pseudocode executes atomically, and only executes if the section above completes without any exceptions or interrupt" requires that adjusting the stack register, writing to the a0 register and returning should be executed atomically.