Repository navigation
feat: small changes to improve UI #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3afd942
feat: small changes to improve UI
jesusbalderramawgu a419bc9
fix: changes back after rebase
jesusbalderramawgu 4b01de5
fix: tests fixed
jesusbalderramawgu 5d4b8ed
fix: id messages and imports fixed
jesusbalderramawgu 2ebe3c6
fix: results label back above the table
jesusbalderramawgu 7c63082
fix: small ui fixes
jesusbalderramawgu 1ba5da0
refactor: course name added to view
jesusbalderramawgu 347b586
fix: test updated
jesusbalderramawgu 96158d6
fix: minor changes in UI
jesusbalderramawgu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| import { useIntl } from '@openedx/frontend-base'; | ||
| import { Bubble } from '@openedx/paragon'; | ||
|
|
||
| import { useFilters } from '@src/data/filtersContext'; | ||
|
Comment on lines
1
to
5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: restore the blank lines between import groups (third-party, |
||
|
|
||
|
|
@@ -17,7 +17,6 @@ import ScoreViewInput from './ScoreViewInput'; | |
| import SearchControls from './SearchControls'; | ||
| import SpinnerIcon from './SpinnerIcon'; | ||
| import StatusAlerts from './StatusAlerts'; | ||
|
|
||
| import { useRefetchGrades } from './data/hooks'; | ||
| import messages from './messages'; | ||
|
|
||
|
|
@@ -40,23 +39,33 @@ export const GradesView = ({ updateQueryParams }) => { | |
| <SpinnerIcon /> | ||
|
|
||
| <InterventionsReport /> | ||
| <h3 className="step-message-1"> | ||
| {formatMessage(messages.filterStepHeading)} | ||
| </h3> | ||
|
|
||
| <div className="d-flex justify-content-between flex-wrap"> | ||
| <FilterMenuToggle /> | ||
| <SearchControls /> | ||
| </div> | ||
|
|
||
| <FilterBadges handleClose={handleFilterBadgeClose} /> | ||
| <StatusAlerts /> | ||
|
|
||
| <h3>{formatMessage(messages.gradebookStepHeading)}</h3> | ||
|
|
||
| <div className="d-flex justify-content-between align-items-center mb-2"> | ||
| <ScoreViewInput /> | ||
| <BulkManagementControls /> | ||
| <div className="mb-3"> | ||
| <div className="d-flex align-items-center mb-2"> | ||
| <Bubble className="mr-2">1</Bubble> | ||
| <h3 className="h4 text-primary-700 my-0"> | ||
| {formatMessage(messages.filterStepHeading)} | ||
| </h3> | ||
| </div> | ||
| <div className="d-flex justify-content-between flex-wrap"> | ||
| <FilterMenuToggle /> | ||
| <SearchControls /> | ||
| </div> | ||
|
|
||
| <FilterBadges handleClose={handleFilterBadgeClose} /> | ||
| <StatusAlerts /> | ||
|
|
||
| <div className="d-flex align-items-center mb-2"> | ||
| <Bubble className="mr-2">2</Bubble> | ||
| <h3 className="h4 text-primary-700 my-0"> | ||
| {formatMessage(messages.gradebookStepHeading)} | ||
| </h3> | ||
| </div> | ||
|
|
||
| <div className="d-flex justify-content-between align-items-center mb-2"> | ||
| <ScoreViewInput /> | ||
| <BulkManagementControls /> | ||
| </div> | ||
| </div> | ||
|
|
||
| <FilteredUsersLabel /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.